Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Side by Side Diff: cc/layers/surface_layer_impl.cc

Issue 2425923003: Replaced is_null() with is_valid in SurfaceId and related classes. (Closed)
Patch Set: Rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/layers/surface_layer.cc ('k') | cc/layers/surface_layer_impl_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/layers/surface_layer_impl.h" 5 #include "cc/layers/surface_layer_impl.h"
6 6
7 #include <stdint.h> 7 #include <stdint.h>
8 8
9 #include "base/trace_event/trace_event_argument.h" 9 #include "base/trace_event/trace_event_argument.h"
10 #include "cc/debug/debug_colors.h" 10 #include "cc/debug/debug_colors.h"
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
63 } 63 }
64 64
65 void SurfaceLayerImpl::AppendQuads(RenderPass* render_pass, 65 void SurfaceLayerImpl::AppendQuads(RenderPass* render_pass,
66 AppendQuadsData* append_quads_data) { 66 AppendQuadsData* append_quads_data) {
67 AppendRainbowDebugBorder(render_pass); 67 AppendRainbowDebugBorder(render_pass);
68 68
69 SharedQuadState* shared_quad_state = 69 SharedQuadState* shared_quad_state =
70 render_pass->CreateAndAppendSharedQuadState(); 70 render_pass->CreateAndAppendSharedQuadState();
71 PopulateScaledSharedQuadState(shared_quad_state, surface_scale_); 71 PopulateScaledSharedQuadState(shared_quad_state, surface_scale_);
72 72
73 if (surface_id_.is_null()) 73 if (!surface_id_.is_valid())
74 return; 74 return;
75 75
76 gfx::Rect quad_rect(surface_size_); 76 gfx::Rect quad_rect(surface_size_);
77 gfx::Rect visible_quad_rect = 77 gfx::Rect visible_quad_rect =
78 draw_properties().occlusion_in_content_space.GetUnoccludedContentRect( 78 draw_properties().occlusion_in_content_space.GetUnoccludedContentRect(
79 quad_rect); 79 quad_rect);
80 if (visible_quad_rect.IsEmpty()) 80 if (visible_quad_rect.IsEmpty())
81 return; 81 return;
82 SurfaceDrawQuad* quad = 82 SurfaceDrawQuad* quad =
83 render_pass->CreateAndAppendDrawQuad<SurfaceDrawQuad>(); 83 render_pass->CreateAndAppendDrawQuad<SurfaceDrawQuad>();
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
180 void SurfaceLayerImpl::AsValueInto(base::trace_event::TracedValue* dict) const { 180 void SurfaceLayerImpl::AsValueInto(base::trace_event::TracedValue* dict) const {
181 LayerImpl::AsValueInto(dict); 181 LayerImpl::AsValueInto(dict);
182 dict->SetString("surface_id", surface_id_.ToString()); 182 dict->SetString("surface_id", surface_id_.ToString());
183 } 183 }
184 184
185 const char* SurfaceLayerImpl::LayerTypeAsString() const { 185 const char* SurfaceLayerImpl::LayerTypeAsString() const {
186 return "cc::SurfaceLayerImpl"; 186 return "cc::SurfaceLayerImpl";
187 } 187 }
188 188
189 } // namespace cc 189 } // namespace cc
OLDNEW
« no previous file with comments | « cc/layers/surface_layer.cc ('k') | cc/layers/surface_layer_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698