Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: ui/android/delegated_frame_host_android.cc

Issue 2425923003: Replaced is_null() with is_valid in SurfaceId and related classes. (Closed)
Patch Set: Fixed an exo compile error Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/android/delegated_frame_host_android.h" 5 #include "ui/android/delegated_frame_host_android.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/logging.h" 8 #include "base/logging.h"
9 #include "cc/layers/solid_color_layer.h" 9 #include "cc/layers/solid_color_layer.h"
10 #include "cc/layers/surface_layer.h" 10 #include "cc/layers/surface_layer.h"
(...skipping 207 matching lines...) Expand 10 before | Expand all | Expand 10 after
218 void DelegatedFrameHostAndroid::UpdateContainerSizeinDIP( 218 void DelegatedFrameHostAndroid::UpdateContainerSizeinDIP(
219 const gfx::Size& size_in_dip) { 219 const gfx::Size& size_in_dip) {
220 container_size_in_dip_ = size_in_dip; 220 container_size_in_dip_ = size_in_dip;
221 background_layer_->SetBounds(gfx::ConvertSizeToPixel( 221 background_layer_->SetBounds(gfx::ConvertSizeToPixel(
222 gfx::DeviceDisplayInfo().GetDIPScale(), container_size_in_dip_)); 222 gfx::DeviceDisplayInfo().GetDIPScale(), container_size_in_dip_));
223 UpdateBackgroundLayer(); 223 UpdateBackgroundLayer();
224 } 224 }
225 225
226 void DelegatedFrameHostAndroid::RegisterFrameSinkHierarchy( 226 void DelegatedFrameHostAndroid::RegisterFrameSinkHierarchy(
227 const cc::FrameSinkId& parent_id) { 227 const cc::FrameSinkId& parent_id) {
228 if (!registered_parent_frame_sink_id_.is_null()) 228 if (registered_parent_frame_sink_id_.is_valid())
229 UnregisterFrameSinkHierarchy(); 229 UnregisterFrameSinkHierarchy();
230 registered_parent_frame_sink_id_ = parent_id; 230 registered_parent_frame_sink_id_ = parent_id;
231 surface_manager_->RegisterSurfaceFactoryClient(frame_sink_id_, this); 231 surface_manager_->RegisterSurfaceFactoryClient(frame_sink_id_, this);
232 surface_manager_->RegisterFrameSinkHierarchy(parent_id, frame_sink_id_); 232 surface_manager_->RegisterFrameSinkHierarchy(parent_id, frame_sink_id_);
233 } 233 }
234 234
235 void DelegatedFrameHostAndroid::UnregisterFrameSinkHierarchy() { 235 void DelegatedFrameHostAndroid::UnregisterFrameSinkHierarchy() {
236 if (registered_parent_frame_sink_id_.is_null()) 236 if (!registered_parent_frame_sink_id_.is_valid())
237 return; 237 return;
238 surface_manager_->UnregisterSurfaceFactoryClient(frame_sink_id_); 238 surface_manager_->UnregisterSurfaceFactoryClient(frame_sink_id_);
239 surface_manager_->UnregisterFrameSinkHierarchy( 239 surface_manager_->UnregisterFrameSinkHierarchy(
240 registered_parent_frame_sink_id_, frame_sink_id_); 240 registered_parent_frame_sink_id_, frame_sink_id_);
241 registered_parent_frame_sink_id_ = cc::FrameSinkId(); 241 registered_parent_frame_sink_id_ = cc::FrameSinkId();
242 } 242 }
243 243
244 void DelegatedFrameHostAndroid::ReturnResources( 244 void DelegatedFrameHostAndroid::ReturnResources(
245 const cc::ReturnedResourceArray& resources) { 245 const cc::ReturnedResourceArray& resources) {
246 return_resources_callback_.Run(resources); 246 return_resources_callback_.Run(resources);
(...skipping 20 matching lines...) Expand all
267 content_size_in_dip.width() < container_size_in_dip_.width() || 267 content_size_in_dip.width() < container_size_in_dip_.width() ||
268 content_size_in_dip.height() < container_size_in_dip_.height(); 268 content_size_in_dip.height() < container_size_in_dip_.height();
269 } else { 269 } else {
270 background_is_drawable = true; 270 background_is_drawable = true;
271 } 271 }
272 272
273 background_layer_->SetIsDrawable(background_is_drawable); 273 background_layer_->SetIsDrawable(background_is_drawable);
274 } 274 }
275 275
276 } // namespace ui 276 } // namespace ui
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698