Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2425913002:
[build] Switch off warning on gcc bots. (Closed)
|
Created:
4 years, 2 months ago by Michael Achenbach Modified:
4 years, 2 months ago CC:
v8-reviews_googlegroups.com Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[build] Switch off warning on gcc bots.
Switch off maybe-uninitialized warning as it gives often
false positives with optimizations in gcc.
NOTRY=true
TBR=bmeurer@chromium.org, zhengxing.li@intel.com, caitp@igalia.com, ahaas@chromium.org
Committed: https://crrev.com/0ef0d5b2b8cffd1e3647d79c5ba19752bbbc469c
Committed: https://crrev.com/c2c6a9a6352f686bdbf94cdc7c2731b6fd668a95
Cr-Original-Commit-Position: refs/heads/master@{#40382}
Cr-Commit-Position: refs/heads/master@{#40394}
Patch Set 1 #Patch Set 2 : [build] Switch off warning on gcc bots. #Patch Set 3 : Fix #Messages
Total messages: 20 (10 generated)
Description was changed from ========== [build] Add more warnings to gcc bots. BUG= ========== to ========== [build] Switch off warning on gcc bots. BUG= ==========
Description was changed from ========== [build] Switch off warning on gcc bots. BUG= ========== to ========== [build] Switch off warning on gcc bots. Switch off maybe-uninitialized warning as it gives often false positives with optimizations in gcc. NOTRY=true TBR=bmeurer@chromium.org, zhengxing.li@intel.com, caitp@igalia.com, ahaas@chromium.org ==========
machenbach@chromium.org changed reviewers: + ahaas@chromium.org, bmeurer@chromium.org, caitp@igalia.com, zhengxing.li@intel.com
PTAL - Chromium has this off in gn: https://cs.chromium.org/chromium/src/build/config/compiler/BUILD.gn?q=%22mayb...
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [build] Switch off warning on gcc bots. Switch off maybe-uninitialized warning as it gives often false positives with optimizations in gcc. NOTRY=true TBR=bmeurer@chromium.org, zhengxing.li@intel.com, caitp@igalia.com, ahaas@chromium.org ========== to ========== [build] Switch off warning on gcc bots. Switch off maybe-uninitialized warning as it gives often false positives with optimizations in gcc. NOTRY=true TBR=bmeurer@chromium.org, zhengxing.li@intel.com, caitp@igalia.com, ahaas@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [build] Switch off warning on gcc bots. Switch off maybe-uninitialized warning as it gives often false positives with optimizations in gcc. NOTRY=true TBR=bmeurer@chromium.org, zhengxing.li@intel.com, caitp@igalia.com, ahaas@chromium.org ========== to ========== [build] Switch off warning on gcc bots. Switch off maybe-uninitialized warning as it gives often false positives with optimizations in gcc. NOTRY=true TBR=bmeurer@chromium.org, zhengxing.li@intel.com, caitp@igalia.com, ahaas@chromium.org Committed: https://crrev.com/0ef0d5b2b8cffd1e3647d79c5ba19752bbbc469c Cr-Commit-Position: refs/heads/master@{#40382} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/0ef0d5b2b8cffd1e3647d79c5ba19752bbbc469c Cr-Commit-Position: refs/heads/master@{#40382}
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2422103006/ by machenbach@chromium.org. The reason for reverting is: Seems to be the wrong flag: https://build.chromium.org/p/client.v8.ports/builders/V8%20Mips%20-%20builder....
Message was sent while issue was closed.
Meh, the gcc gcov bot greenified by this CL: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20gcov%20cov... But the mips builder didn't and complained about the flag. Guess they use different gcc versions :(
Message was sent while issue was closed.
Description was changed from ========== [build] Switch off warning on gcc bots. Switch off maybe-uninitialized warning as it gives often false positives with optimizations in gcc. NOTRY=true TBR=bmeurer@chromium.org, zhengxing.li@intel.com, caitp@igalia.com, ahaas@chromium.org Committed: https://crrev.com/0ef0d5b2b8cffd1e3647d79c5ba19752bbbc469c Cr-Commit-Position: refs/heads/master@{#40382} ========== to ========== [build] Switch off warning on gcc bots. Switch off maybe-uninitialized warning as it gives often false positives with optimizations in gcc. NOTRY=true TBR=bmeurer@chromium.org, zhengxing.li@intel.com, caitp@igalia.com, ahaas@chromium.org Committed: https://crrev.com/0ef0d5b2b8cffd1e3647d79c5ba19752bbbc469c Cr-Commit-Position: refs/heads/master@{#40382} ==========
Removing now -Wno-uninitialized which seems to work with the mips and the gcov gyp gcc bots.
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [build] Switch off warning on gcc bots. Switch off maybe-uninitialized warning as it gives often false positives with optimizations in gcc. NOTRY=true TBR=bmeurer@chromium.org, zhengxing.li@intel.com, caitp@igalia.com, ahaas@chromium.org Committed: https://crrev.com/0ef0d5b2b8cffd1e3647d79c5ba19752bbbc469c Cr-Commit-Position: refs/heads/master@{#40382} ========== to ========== [build] Switch off warning on gcc bots. Switch off maybe-uninitialized warning as it gives often false positives with optimizations in gcc. NOTRY=true TBR=bmeurer@chromium.org, zhengxing.li@intel.com, caitp@igalia.com, ahaas@chromium.org Committed: https://crrev.com/0ef0d5b2b8cffd1e3647d79c5ba19752bbbc469c Cr-Commit-Position: refs/heads/master@{#40382} ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [build] Switch off warning on gcc bots. Switch off maybe-uninitialized warning as it gives often false positives with optimizations in gcc. NOTRY=true TBR=bmeurer@chromium.org, zhengxing.li@intel.com, caitp@igalia.com, ahaas@chromium.org Committed: https://crrev.com/0ef0d5b2b8cffd1e3647d79c5ba19752bbbc469c Cr-Commit-Position: refs/heads/master@{#40382} ========== to ========== [build] Switch off warning on gcc bots. Switch off maybe-uninitialized warning as it gives often false positives with optimizations in gcc. NOTRY=true TBR=bmeurer@chromium.org, zhengxing.li@intel.com, caitp@igalia.com, ahaas@chromium.org Committed: https://crrev.com/0ef0d5b2b8cffd1e3647d79c5ba19752bbbc469c Committed: https://crrev.com/c2c6a9a6352f686bdbf94cdc7c2731b6fd668a95 Cr-Original-Commit-Position: refs/heads/master@{#40382} Cr-Commit-Position: refs/heads/master@{#40394} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/c2c6a9a6352f686bdbf94cdc7c2731b6fd668a95 Cr-Commit-Position: refs/heads/master@{#40394} |
