Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1130)

Unified Diff: test/mjsunit/regress/regress-crbug-656037.js

Issue 2425903002: [turbofan] Fix return value of Array.prototype.push. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/typer.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mjsunit/regress/regress-crbug-656037.js
diff --git a/test/mjsunit/regress/regress-5357.js b/test/mjsunit/regress/regress-crbug-656037.js
similarity index 70%
copy from test/mjsunit/regress/regress-5357.js
copy to test/mjsunit/regress/regress-crbug-656037.js
index 11ada60708fb233d7f02b707e7e9037611b0ec8b..47d09aaa4b9d466574eea9c5ecbd3c5af54cf911 100644
--- a/test/mjsunit/regress/regress-5357.js
+++ b/test/mjsunit/regress/regress-crbug-656037.js
@@ -5,13 +5,11 @@
// Flags: --allow-natives-syntax
function foo(a) {
- a++;
- a = Math.max(0, a);
- a++;
- return a;
+ return a.push(true);
}
-foo(0);
-foo(0);
+var a = [];
+assertEquals(1, foo(a));
+assertEquals(2, foo(a));
%OptimizeFunctionOnNextCall(foo);
-assertEquals(2147483648, foo(2147483646));
+assertEquals(3, foo(a));
« no previous file with comments | « src/compiler/typer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698