Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(807)

Issue 2425903002: [turbofan] Fix return value of Array.prototype.push. (Closed)

Created:
4 years, 2 months ago by Benedikt Meurer
Modified:
4 years, 2 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix return value of Array.prototype.push. The inlined version of Array.prototype.push returned the value that was pushed instead of the new "length" property value. R=jarin@chromium.org BUG=chromium:656037 Committed: https://crrev.com/85844420a2cab6e8f4582e462b28f7f86db2d651 Cr-Commit-Position: refs/heads/master@{#40384}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -7 lines) Patch
M src/compiler/js-builtin-reducer.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +2 lines, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-656037.js View 1 chunk +5 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Benedikt Meurer
4 years, 2 months ago (2016-10-18 04:44:22 UTC) #1
Benedikt Meurer
Hey Jaro, Here's a quick fix for the Array.prototype.push inlining. Please take a look. Thanks, ...
4 years, 2 months ago (2016-10-18 04:46:30 UTC) #4
Jarin
lgtm
4 years, 2 months ago (2016-10-18 07:58:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2425903002/1
4 years, 2 months ago (2016-10-18 07:58:37 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-18 08:01:53 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-18 08:02:31 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/85844420a2cab6e8f4582e462b28f7f86db2d651
Cr-Commit-Position: refs/heads/master@{#40384}

Powered by Google App Engine
This is Rietveld 408576698