Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Side by Side Diff: src/heap-inl.h

Issue 24259005: Revert ("Chromium 284577 needs a mitigation CL added." (svn-id 16742)) (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/objects.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 507 matching lines...) Expand 10 before | Expand all | Expand 10 after
518 518
519 // If the first word is a forwarding address, the object has already been 519 // If the first word is a forwarding address, the object has already been
520 // copied. 520 // copied.
521 if (first_word.IsForwardingAddress()) { 521 if (first_word.IsForwardingAddress()) {
522 HeapObject* dest = first_word.ToForwardingAddress(); 522 HeapObject* dest = first_word.ToForwardingAddress();
523 ASSERT(object->GetIsolate()->heap()->InFromSpace(*p)); 523 ASSERT(object->GetIsolate()->heap()->InFromSpace(*p));
524 *p = dest; 524 *p = dest;
525 return; 525 return;
526 } 526 }
527 527
528 // TODO(hpayer): temporary debugging code for issue 284577. 528 // AllocationMementos are unrooted and shouldn't survive a scavenge
529 CHECK(object->map() != object->GetHeap()->allocation_memento_map()); 529 ASSERT(object->map() != object->GetHeap()->allocation_memento_map());
530 // Call the slow part of scavenge object. 530 // Call the slow part of scavenge object.
531 return ScavengeObjectSlow(p, object); 531 return ScavengeObjectSlow(p, object);
532 } 532 }
533 533
534 534
535 bool Heap::CollectGarbage(AllocationSpace space, const char* gc_reason) { 535 bool Heap::CollectGarbage(AllocationSpace space, const char* gc_reason) {
536 const char* collector_reason = NULL; 536 const char* collector_reason = NULL;
537 GarbageCollector collector = SelectGarbageCollector(space, &collector_reason); 537 GarbageCollector collector = SelectGarbageCollector(space, &collector_reason);
538 return CollectGarbage(space, collector, gc_reason, collector_reason); 538 return CollectGarbage(space, collector, gc_reason, collector_reason);
539 } 539 }
(...skipping 341 matching lines...) Expand 10 before | Expand all | Expand 10 after
881 #ifdef DEBUG 881 #ifdef DEBUG
882 Isolate* isolate = Isolate::Current(); 882 Isolate* isolate = Isolate::Current();
883 isolate->heap()->disallow_allocation_failure_ = old_state_; 883 isolate->heap()->disallow_allocation_failure_ = old_state_;
884 #endif 884 #endif
885 } 885 }
886 886
887 887
888 } } // namespace v8::internal 888 } } // namespace v8::internal
889 889
890 #endif // V8_HEAP_INL_H_ 890 #endif // V8_HEAP_INL_H_
OLDNEW
« no previous file with comments | « no previous file | src/objects.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698