Issue 24259005: Revert ("Chromium 284577 needs a mitigation CL added." (svn-id 16742))

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24259005: Revert ("Chromium 284577 needs a mitigation CL added." (svn-id 16742)) (Closed)

Created:
7 years, 3 months ago by mvstanton

Modified:
7 years, 3 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Revert ("Chromium 284577 needs a mitigation CL added." (svn-id 16742)) Also change a check in heap-inl.h for diagnosing 284577 into an assert. BUG= R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16816

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -14 lines)			Patch
	M	src/heap-inl.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	src/objects.cc	View		1 chunk	+1 line, -12 lines	0 comments	Download

Total messages: 3 (0 generated)

mvstanton

Hi Michael, I thought you'd like to aid in this revert :). Thanks, --Michael

7 years, 3 months ago (2013-09-19 08:46:06 UTC) #1

mvstanton

7 years, 3 months ago (2013-09-19 09:15:38 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r16816 (presubmit successful).