[Findit] Modify Findit API to return more information to Sheriff-O-Matic.

appengine/findit/handlers/test/build_failure_test.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import os
 import re
 
 from google.appengine.ext import testbed
 
 import webapp2
@@ skipping 764 matching lines @@
         'first_failure': 122,
         'last_pass': 121,
         'suspected_cls_by_heuristic': [],
     }
 
     data = {}
     build_failure._PopulateHeuristicDataForCompileFailure(
         analysis, data)
     self.assertEqual(expected_data, data)
 
+  def _PercentFormat(self, float_number):
+    return '%d%%' % (round(float_number * 100))
+
   def testGetTryJobResultForCompileFailure(self):
     analysis = WfAnalysis.Create('m', 'b', 123)
     analysis.result = {
         'failures': [
             {
                 'step_name': 'compile',
                 'first_failure': 122,
                 'last_pass': 121,
                 'suspected_cls': [],
             },
@@ skipping 53 matching lines @@
         'failed': False,
     }
 
     expected_suspected_cls = [
         {
             'repo_name': 'chromium',
             'revision': 'rev',
             'commit_position': 122,
             'url': None,
             'status': suspected_cl_status.CORRECT,
-            'confidence': build_failure._PercentFormat(
+            'confidence': self._PercentFormat(
                 self.cl_confidences.compile_heuristic_try_job.confidence)
         }
     ]
 
     build_url = buildbot.CreateBuildUrl('m', 'b', 123)
     response = self.test_app.get('/build-failure',
                                  params={'url': build_url, 'format': 'json'})
 
     self.assertEquals(200, response.status_int)
     self.assertEqual(expected_try_job_result, response.json_body['try_job'])
@@ skipping 33 matching lines @@
             'commit_position': 122,
             'url': None,
             'status': None,
             'confidence': None
         }
     ]
 
     suspected_cls = build_failure._GetAllSuspectedCLsAndCheckStatus(
         master_name, builder_name, build_number, analysis)
     self.assertEqual(
-        expected_suspected_cls, suspected_cls)
-
-  def testGetConfidenceScoreTestHeuristic(self):
-    build = {
-        'failure_type': failure_type.TEST,
-        'failures': None,
-        'status': suspected_cl_status.CORRECT,
-        'approaches': [analysis_approach_type.HEURISTIC],
-        'top_score': 5
-    }
-
-    self.assertEqual(
-        build_failure._PercentFormat(
-            self.cl_confidences.test_heuristic[1].confidence),
-        build_failure._GetConfidenceScore(self.cl_confidences, build))
-
-  def testGetConfidenceScoreCompileHeuristic(self):
-    build = {
-        'failure_type': failure_type.COMPILE,
-        'failures': None,
-        'status': suspected_cl_status.CORRECT,
-        'approaches': [analysis_approach_type.HEURISTIC],
-        'top_score': 4
-    }
-
-    self.assertEqual(
-        build_failure._PercentFormat(
-            self.cl_confidences.compile_heuristic[1].confidence),
-        build_failure._GetConfidenceScore(self.cl_confidences, build))
-
-  def testGetConfidenceScoreTestTryJob(self):
-    build = {
-        'failure_type': failure_type.TEST,
-        'failures': None,
-        'status': suspected_cl_status.CORRECT,
-        'approaches': [analysis_approach_type.TRY_JOB],
-        'top_score': 5
-    }
-
-    self.assertEqual(
-        build_failure._PercentFormat(
-            self.cl_confidences.test_try_job.confidence),
-        build_failure._GetConfidenceScore(self.cl_confidences, build))
-
-  def testGetConfidenceScoreCompileTryJob(self):
-    build = {
-        'failure_type': failure_type.COMPILE,
-        'failures': None,
-        'status': suspected_cl_status.CORRECT,
-        'approaches': [analysis_approach_type.TRY_JOB],
-        'top_score': 5
-    }
-
-    self.assertEqual(
-        build_failure._PercentFormat(
-            self.cl_confidences.test_try_job.confidence),
-        build_failure._GetConfidenceScore(self.cl_confidences, build))
-
-  def testGetConfidenceScoreTestHeuristicTryJob(self):
-    build = {
-        'failure_type': failure_type.TEST,
-        'failures': None,
-        'status': suspected_cl_status.CORRECT,
-        'approaches': [analysis_approach_type.HEURISTIC,
-                       analysis_approach_type.TRY_JOB],
-        'top_score': 5
-    }
-
-    self.assertEqual(
-        build_failure._PercentFormat(
-            self.cl_confidences.test_heuristic_try_job.confidence),
-        build_failure._GetConfidenceScore(self.cl_confidences, build))
-
-  def testGetConfidenceScoreNone(self):
-    self.assertIsNone(build_failure._GetConfidenceScore(None, None))
-
-  def testGetConfidenceScoreUnexpected(self):
-    build = {
-        'failure_type': failure_type.COMPILE,
-        'failures': None,
-        'status': suspected_cl_status.CORRECT,
-        'approaches': [analysis_approach_type.HEURISTIC],
-        'top_score': 2
-    }
-
-    self.assertIsNone(build_failure._GetConfidenceScore(
-        self.cl_confidences, build))
-
-  def testGetConfidenceScoreCompileNone(self):
-    build = {
-      'failure_type': failure_type.COMPILE,
-      'approaches': []
-    }
-    self.assertIsNone(build_failure._GetConfidenceScore(
-        self.cl_confidences, build))
-
-  def testGetConfidenceScoreUnexpectedTest(self):
-    build = {
-        'failure_type': failure_type.TEST,
-        'failures': None,
-        'status': suspected_cl_status.CORRECT,
-        'approaches': [analysis_approach_type.HEURISTIC],
-        'top_score': 2
-    }
-
-    self.assertIsNone(build_failure._GetConfidenceScore(
-        self.cl_confidences, build))
-
-  def testGetConfidenceScoreTestNone(self):
-    build = {
-      'failure_type': failure_type.TEST,
-      'approaches': []
-    }
-    self.assertIsNone(build_failure._GetConfidenceScore(
-        self.cl_confidences, build))
-
-  def testPercentFormatNone(self):
-    self.assertIsNone(build_failure._PercentFormat(None))
+        expected_suspected_cls, suspected_cls)