Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2425853005: [Findit] Modify Findit API to return more information to Sheriff-O-Matic. (Closed)

Created:
4 years, 2 months ago by chanli
Modified:
4 years, 1 month ago
Reviewers:
stgao, lijeffrey
CC:
chromium-reviews, infra-reviews+infra_chromium.org, Sharu Jiang
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

[Findit] Modify Findit API to return more information to Sheriff-O-Matic. 1. Add a flag (is_flaky_test) to mark if the result is for flaky test. 2. Add try_job_status. 3. Add confidence score for each suspected_cl. 4. Add analysis_approach for each suspected_cl. BUG=609240, 655234 Committed: https://chromium.googlesource.com/infra/infra/+/3b1a71cedd4d149ed646ce175b51ee03fd9908ee

Patch Set 1 #

Patch Set 2 : fix nits #

Total comments: 9

Patch Set 3 : Address comments #

Patch Set 4 : rebase #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+603 lines, -240 lines) Patch
M appengine/findit/findit_api.py View 1 2 9 chunks +122 lines, -37 lines 0 comments Download
M appengine/findit/handlers/build_failure.py View 1 2 3 4 6 chunks +5 lines, -41 lines 0 comments Download
M appengine/findit/handlers/test/build_failure_test.py View 1 2 3 4 4 chunks +5 lines, -118 lines 0 comments Download
A appengine/findit/model/test/wf_suspected_cl_test.py View 1 chunk +22 lines, -0 lines 0 comments Download
M appengine/findit/model/wf_suspected_cl.py View 3 chunks +38 lines, -40 lines 0 comments Download
M appengine/findit/test/findit_api_test.py View 1 2 3 11 chunks +206 lines, -3 lines 0 comments Download
M appengine/findit/waterfall/build_util.py View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M appengine/findit/waterfall/suspected_cl_util.py View 1 2 3 4 2 chunks +39 lines, -0 lines 0 comments Download
M appengine/findit/waterfall/test/suspected_cl_util_test.py View 1 2 3 4 2 chunks +165 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (6 generated)
chanli
ptal
4 years, 2 months ago (2016-10-18 20:50:47 UTC) #2
stgao
I will review this later today. But I have a question: will this API change ...
4 years, 2 months ago (2016-10-18 21:06:22 UTC) #3
stgao
Looks pretty good. https://codereview.chromium.org/2425853005/diff/20001/appengine/findit/findit_api.py File appengine/findit/findit_api.py (right): https://codereview.chromium.org/2425853005/diff/20001/appengine/findit/findit_api.py#newcode75 appengine/findit/findit_api.py:75: class _TryJobStatus(messages.Enum): More status here: 1. ...
4 years, 2 months ago (2016-10-19 00:43:08 UTC) #4
chanli
https://codereview.chromium.org/2425853005/diff/20001/appengine/findit/findit_api.py File appengine/findit/findit_api.py (right): https://codereview.chromium.org/2425853005/diff/20001/appengine/findit/findit_api.py#newcode75 appengine/findit/findit_api.py:75: class _TryJobStatus(messages.Enum): On 2016/10/19 00:43:08, stgao wrote: > More ...
4 years, 2 months ago (2016-10-19 03:00:59 UTC) #5
stgao
https://codereview.chromium.org/2425853005/diff/20001/appengine/findit/findit_api.py File appengine/findit/findit_api.py (right): https://codereview.chromium.org/2425853005/diff/20001/appengine/findit/findit_api.py#newcode75 appengine/findit/findit_api.py:75: class _TryJobStatus(messages.Enum): On 2016/10/19 03:00:59, chanli wrote: > On ...
4 years, 2 months ago (2016-10-21 01:51:22 UTC) #6
stgao
lgtm Per discussion, we should hold the CL until SoM is changed to be ready ...
4 years, 2 months ago (2016-10-22 00:24:15 UTC) #7
chanli
https://codereview.chromium.org/2425853005/diff/20001/appengine/findit/findit_api.py File appengine/findit/findit_api.py (right): https://codereview.chromium.org/2425853005/diff/20001/appengine/findit/findit_api.py#newcode258 appengine/findit/findit_api.py:258: swarming_task = WfSwarmingTask.Get(*try_job_key.split('/'), On 2016/10/22 00:24:14, stgao wrote: > ...
4 years, 1 month ago (2016-10-24 18:30:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2425853005/80001
4 years, 1 month ago (2016-10-28 01:12:58 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: Infra Win Tester on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/3221c72c6db82310)
4 years, 1 month ago (2016-10-28 02:15:31 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2425853005/80001
4 years, 1 month ago (2016-10-28 02:21:00 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 02:30:00 UTC) #17
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/infra/infra/+/3b1a71cedd4d149ed646ce175b51e...

Powered by Google App Engine
This is Rietveld 408576698