Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 2425853003: Begin separating API and local element builders. (Closed)

Created:
4 years, 2 months ago by scheglov
Modified:
4 years, 2 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Begin separating API and local element builders. I will write separate tests for them and do some more clean up in separate CLs. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/e1f8a0a103aac962e1eb8ce48971e133a764af70

Patch Set 1 #

Patch Set 2 : Don't visit function bodies in ApiElementBuilder. #

Total comments: 2

Patch Set 3 : remove debug code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+949 lines, -809 lines) Patch
M pkg/analyzer/lib/src/dart/element/builder.dart View 1 12 chunks +891 lines, -694 lines 0 comments Download
M pkg/analyzer/test/generated/all_the_rest_test.dart View 10 chunks +58 lines, -115 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
scheglov
4 years, 2 months ago (2016-10-17 22:29:01 UTC) #1
Brian Wilkerson
lgtm https://codereview.chromium.org/2425853003/diff/20001/pkg/analyzer/lib/src/generated/resolver.dart File pkg/analyzer/lib/src/generated/resolver.dart (right): https://codereview.chromium.org/2425853003/diff/20001/pkg/analyzer/lib/src/generated/resolver.dart#newcode6561 pkg/analyzer/lib/src/generated/resolver.dart:6561: print('aaa'); I assume this is debugging code that ...
4 years, 2 months ago (2016-10-18 00:18:29 UTC) #2
scheglov
https://codereview.chromium.org/2425853003/diff/20001/pkg/analyzer/lib/src/generated/resolver.dart File pkg/analyzer/lib/src/generated/resolver.dart (right): https://codereview.chromium.org/2425853003/diff/20001/pkg/analyzer/lib/src/generated/resolver.dart#newcode6561 pkg/analyzer/lib/src/generated/resolver.dart:6561: print('aaa'); On 2016/10/18 00:18:29, Brian Wilkerson wrote: > I ...
4 years, 2 months ago (2016-10-18 01:50:58 UTC) #3
Paul Berry
lgtm
4 years, 2 months ago (2016-10-18 12:53:30 UTC) #4
scheglov
4 years, 2 months ago (2016-10-18 15:22:39 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
e1f8a0a103aac962e1eb8ce48971e133a764af70 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698