Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 2425843002: Fix segv in AddImage() (Closed)

Created:
4 years, 2 months ago by Tom Sepez
Modified:
4 years, 2 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Fix segv in AddImage() The assumption that only indirect objects would be passed is wrong. Restore old behaviour despite muddying ownership constraints. R=thestig@chromium.org BUG=656145 Committed: https://pdfium.googlesource.com/pdfium/+/c11287728d15bcc2c431f4b3c6eba8b5a79f906b

Patch Set 1 #

Patch Set 2 : Fix ownership #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M core/fpdfapi/page/cpdf_streamcontentparser.cpp View 1 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 14 (10 generated)
Tom Sepez
Lei, for review.
4 years, 2 months ago (2016-10-17 21:15:12 UTC) #7
Lei Zhang
lgtm
4 years, 2 months ago (2016-10-17 22:31:21 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2425843002/20001
4 years, 2 months ago (2016-10-17 22:35:58 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 22:36:15 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/c11287728d15bcc2c431f4b3c6eba8b5a79f...

Powered by Google App Engine
This is Rietveld 408576698