Issue 24258006: don't use default isolate in mksnapshot

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24258006: don't use default isolate in mksnapshot (Closed)

Created:
7 years, 3 months ago by dcarney

Modified:
7 years, 3 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	src/mksnapshot.cc	View		2 chunks	+5 lines, -1 line	0 comments	Download
	M	src/serialize.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Sven Panne

LGTM, let's hope that there are no hidden assumptions about the default isolate deep in ...

7 years, 3 months ago (2013-09-20 11:00:52 UTC) #2

dcarney

7 years, 3 months ago (2013-09-20 13:19:56 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r16869 (presubmit successful).