Issue 24258003: Type warning fix for: Add string art GM and sample.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24258003: Type warning fix for: Add string art GM and sample. (Closed)

Created:
7 years, 3 months ago by jvanverth1

Modified:
7 years, 3 months ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Type warning fix for: Add string art GM and sample. R=robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=11384

Patch Set 2 : Rebase to master #

Total comments: 4

Patch Set 4 : Missing nit #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	gm/stringart.cpp	View	1 2	2 chunks	+3 lines, -3 lines	0 comments	Download
	M	samplecode/SampleStringArt.cpp	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

robertphillips

lgtm + 2 questions/ideas https://codereview.chromium.org/24258003/diff/3001/gm/stringart.cpp File gm/stringart.cpp (right): https://codereview.chromium.org/24258003/diff/3001/gm/stringart.cpp#newcode13 gm/stringart.cpp:13: SkIntToScalar? https://codereview.chromium.org/24258003/diff/3001/gm/stringart.cpp#newcode35 gm/stringart.cpp:35: SkScalar angle ...

7 years, 3 months ago (2013-09-19 16:19:01 UTC) #2

jvanverth1

https://codereview.chromium.org/24258003/diff/3001/gm/stringart.cpp File gm/stringart.cpp (right): https://codereview.chromium.org/24258003/diff/3001/gm/stringart.cpp#newcode13 gm/stringart.cpp:13: On 2013/09/19 16:19:01, robertphillips wrote: > SkIntToScalar? Done. https://codereview.chromium.org/24258003/diff/3001/gm/stringart.cpp#newcode35 ...

7 years, 3 months ago (2013-09-19 16:32:35 UTC) #3

jvanverth1

7 years, 3 months ago (2013-09-19 16:32:56 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 manually as r11384 (presubmit successful).