Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 2425763002: [NTP] Add functionality to ViewUtils to setEnabled recursively. (Closed)

Created:
4 years, 2 months ago by PEConn
Modified:
4 years, 2 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, ntp-dev+reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NTP] Add functionality to ViewUtils to setEnabled recursively. BUG=655985 Committed: https://crrev.com/1f5cf0a30fde0d6534ef11af4cd6b2fb5cd99bba Cr-Commit-Position: refs/heads/master@{#425931}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -20 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java View 3 chunks +3 lines, -5 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/ManagedPreferenceDelegate.java View 3 chunks +3 lines, -15 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/util/ViewUtils.java View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
PEConn
PTAL
4 years, 2 months ago (2016-10-17 14:59:58 UTC) #2
Bernhard Bauer
LGTM, thanks!
4 years, 2 months ago (2016-10-17 16:16:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2425763002/1
4 years, 2 months ago (2016-10-18 08:52:07 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-18 09:23:35 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-18 09:26:12 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1f5cf0a30fde0d6534ef11af4cd6b2fb5cd99bba
Cr-Commit-Position: refs/heads/master@{#425931}

Powered by Google App Engine
This is Rietveld 408576698