Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 2425753002: Rename ArcBridgeBootstrap to ArcSession. (Closed)

Created:
4 years, 2 months ago by hidehiko
Modified:
4 years, 2 months ago
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, yusukes+watch_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename ArcBridgeBootstrap to ArcSession. Now, ArcBridgeBootstrap was not only handles bootstrap-phase procedure, but also, e.g., crash handling or shutdown. So, the name did not represent what it was. This CL renames it to ArcSession. BUG=633258 , b/30236819 TEST=Ran on test device. Ran trybots. Committed: https://crrev.com/88160c8517ad770b6a56f773b2174448c443cc11 Cr-Commit-Position: refs/heads/master@{#425933}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -937 lines) Patch
M chrome/browser/chromeos/arc/arc_auth_service_browsertest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/arc/BUILD.gn View 3 chunks +4 lines, -4 lines 0 comments Download
D components/arc/arc_bridge_bootstrap.h View 1 chunk +0 lines, -73 lines 0 comments Download
D components/arc/arc_bridge_bootstrap.cc View 1 chunk +0 lines, -607 lines 0 comments Download
M components/arc/arc_bridge_service.h View 1 chunk +1 line, -1 line 0 comments Download
M components/arc/arc_bridge_service_impl.h View 5 chunks +13 lines, -15 lines 0 comments Download
M components/arc/arc_bridge_service_impl.cc View 5 chunks +14 lines, -14 lines 0 comments Download
M components/arc/arc_bridge_service_unittest.cc View 7 chunks +23 lines, -24 lines 0 comments Download
A + components/arc/arc_session.h View 4 chunks +12 lines, -15 lines 0 comments Download
A + components/arc/arc_session.cc View 1 16 chunks +40 lines, -44 lines 0 comments Download
D components/arc/test/fake_arc_bridge_bootstrap.h View 1 chunk +0 lines, -52 lines 0 comments Download
D components/arc/test/fake_arc_bridge_bootstrap.cc View 1 chunk +0 lines, -59 lines 0 comments Download
A + components/arc/test/fake_arc_session.h View 3 chunks +12 lines, -12 lines 0 comments Download
A + components/arc/test/fake_arc_session.cc View 5 chunks +10 lines, -11 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
hidehiko
PTAL. bartfab@: chrome/browser/policy/policy_browsertest.cc lhchavez@: All. Thank you for your review in advance, - hidehiko
4 years, 2 months ago (2016-10-17 14:50:06 UTC) #4
Luis Héctor Chávez
lgtm with one nit https://codereview.chromium.org/2425753002/diff/1/components/arc/arc_session.cc File components/arc/arc_session.cc (right): https://codereview.chromium.org/2425753002/diff/1/components/arc/arc_session.cc#newcode112 components/arc/arc_session.cc:112: // The possible states of ...
4 years, 2 months ago (2016-10-18 00:24:57 UTC) #7
hidehiko
Thank you for review, Luis. bartfab@, friendly ping? https://codereview.chromium.org/2425753002/diff/1/components/arc/arc_session.cc File components/arc/arc_session.cc (right): https://codereview.chromium.org/2425753002/diff/1/components/arc/arc_session.cc#newcode112 components/arc/arc_session.cc:112: // ...
4 years, 2 months ago (2016-10-18 05:27:45 UTC) #8
bartfab (slow)
policy_browsertest.cc LGTM
4 years, 2 months ago (2016-10-18 08:47:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2425753002/20001
4 years, 2 months ago (2016-10-18 08:48:50 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-18 09:44:16 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-18 09:46:15 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/88160c8517ad770b6a56f773b2174448c443cc11
Cr-Commit-Position: refs/heads/master@{#425933}

Powered by Google App Engine
This is Rietveld 408576698