Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 2425723002: [turbofan] Fixes CodeAssembler::Word32Shr'r rhs operand type. (Closed)

Created:
4 years, 2 months ago by epertoso
Modified:
4 years, 2 months ago
Reviewers:
danno
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fixes CodeAssembler::Word32Shr'r rhs operand type. BUG= Committed: https://crrev.com/ff287be98f231bcfceba12f412611cc0e8c245df Cr-Commit-Position: refs/heads/master@{#40367}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/compiler/code-assembler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
epertoso
4 years, 2 months ago (2016-10-17 14:21:08 UTC) #5
danno
lgtm
4 years, 2 months ago (2016-10-17 14:22:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2425723002/1
4 years, 2 months ago (2016-10-17 14:57:39 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-17 14:59:40 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 15:00:03 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ff287be98f231bcfceba12f412611cc0e8c245df
Cr-Commit-Position: refs/heads/master@{#40367}

Powered by Google App Engine
This is Rietveld 408576698