ios/public/provider/chrome/browser/voice/voice_search_language.h - Issue 2425713002: [ios] Adds configuration helper files for voice search.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/public/provider/chrome/browser/voice/voice_search_language.h

Issue 2425713002: [ios] Adds configuration helper files for voice search. (Closed)

Patch Set: Separate targets. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef IOS_PUBLIC_PROVIDER_CHROME_BROWSER_VOICE_VOICE_SEARCH_LANGUAGE_H_

	6 #define IOS_PUBLIC_PROVIDER_CHROME_BROWSER_VOICE_VOICE_SEARCH_LANGUAGE_H_

	7

	8 #import <Foundation/Foundation.h>

	9

	10 @interface VoiceSearchLanguage : NSObject
	sdefresne 2016/10/17 16:12:40 nit: can you add a initializer that initializes th nit: can you add a initializer that initializes the properties - (instancetype)initWithIdentifier:(NSString)identifier displayName:(NSString)displayName localizationPreference:(NSString*)localizationPreference NS_DESIGNATED_INITIALIZER;
	11

	12 @property(nonatomic, readwrite, copy) NSString* identifier;

	13

	14 @property(nonatomic, readwrite, copy) NSString* displayName;

	15

	16 @property(nonatomic, readwrite, copy) NSString* localizationPreference;

	17

	18 @end

	19

	20 #endif // IOS_PUBLIC_PROVIDER_CHROME_BROWSER_VOICE_VOICE_SEARCH_LANGUAGE_H_

OLD	NEW