Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 2425703007: [builtins] Fix typo in Number.parseInt TurboFan builtin. (Closed)

Created:
4 years, 2 months ago by Benedikt Meurer
Modified:
4 years, 1 month ago
Reviewers:
epertoso
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Fix typo in Number.parseInt TurboFan builtin. http://crrev.com/2424403002 contained a typo comparing the input map against the undefined constant rather than the HeapNumber map, which tanks the case where Number.parseInt is used instead of Math.floor. TBR=epertoso@chromium.org BUG=v8:5049 Committed: https://crrev.com/669a084a2b9247a2cdf14dc0a011905531439c56 Cr-Commit-Position: refs/heads/master@{#40409}

Patch Set 1 #

Patch Set 2 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M src/builtins/builtins-number.cc View 1 2 chunks +9 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2425703007/1
4 years, 2 months ago (2016-10-18 19:06:45 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/builds/6438) v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
4 years, 2 months ago (2016-10-18 19:22:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2425703007/20001
4 years, 2 months ago (2016-10-18 19:32:53 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-18 20:00:39 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:05:09 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/669a084a2b9247a2cdf14dc0a011905531439c56
Cr-Commit-Position: refs/heads/master@{#40409}

Powered by Google App Engine
This is Rietveld 408576698