Chromium Code Reviews| Index: gcl.py |
| =================================================================== |
| --- gcl.py (revision 225035) |
| +++ gcl.py (working copy) |
| @@ -878,7 +878,15 @@ |
| watchlist = watchlists.Watchlists(change_info.GetLocalRoot()) |
| watchers = watchlist.GetWatchersForPaths(change_info.GetFileNames()) |
| - cc_list = GetCodeReviewSetting("CC_LIST") |
| + if "--private" in upload_arg: |
| + # We check this before getting "PRIVATE" setting assuming that the |
| + # author of the settings file has put addresses which we can send |
| + # private CLs to. |
| + Warn("WARNING: CC_LIST is ignored since private flag is specified. " |
| + "You need to review and add it manually.") |
| + cc_list = "" |
|
iannucci
2013/09/24 18:52:54
Could you do the same change for git_cl as well?
tyoshino (SeeGerritForStatus)
2013/09/25 05:10:01
Done.
|
| + else: |
| + cc_list = GetCodeReviewSetting("CC_LIST") |
| if not no_watchlists and watchers: |
| # Filter out all empty elements and join by ',' |
| cc_list = ','.join(filter(None, [cc_list] + watchers)) |