Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Unified Diff: Source/bindings/scripts/unstable/v8_attributes.py

Issue 24257003: IDL compiler: Types (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix copyright + license Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/bindings/scripts/unstable/v8_callback_interface.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/unstable/v8_attributes.py
diff --git a/Source/bindings/scripts/unstable/v8_attributes.py b/Source/bindings/scripts/unstable/v8_attributes.py
index 802f51a28440249a3c78deee58510c6b281a1366..a218625754c1c05b4a1797783b8c4e5ce542bfc1 100644
--- a/Source/bindings/scripts/unstable/v8_attributes.py
+++ b/Source/bindings/scripts/unstable/v8_attributes.py
@@ -73,13 +73,12 @@ def generate_attribute_and_includes(attribute):
includes.add('bindings/v8/V8HiddenPropertyName.h')
else:
cpp_value = 'imp->%s()' % uncapitalize(attribute.name)
- return_v8_value_statement = v8_types.v8_set_return_value(idl_type, cpp_value, callback_info='info')
- includes = []
+ return_v8_value_statement, includes = v8_types.v8_set_return_value(idl_type, cpp_value, callback_info='info', isolate='info.GetIsolate()', extended_attributes=attribute.extended_attributes)
contents = {
'name': attribute.name,
'conditional_string': generate_conditional_string(attribute),
'cpp_method_name': cpp_method_name(attribute),
- 'cpp_type': v8_types.cpp_type(idl_type, pointer_type='RefPtr'),
+ 'cpp_type': v8_types.cpp_type(idl_type),
'should_keep_attribute_alive': should_keep_attribute_alive,
'return_v8_value_statement': return_v8_value_statement,
'v8_type': v8_types.v8_type(idl_type),
« no previous file with comments | « no previous file | Source/bindings/scripts/unstable/v8_callback_interface.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698