Source/bindings/scripts/unstable/v8_callback_interface.py - Issue 24257003: IDL compiler: Types

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/unstable/v8_callback_interface.py

Issue 24257003: IDL compiler: Types (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Revised Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/scripts/unstable/v8_callback_interface.py

diff --git a/Source/bindings/scripts/unstable/v8_callback_interface.py b/Source/bindings/scripts/unstable/v8_callback_interface.py

index ce487865daa70c4292b72a28c872b1e6c06a52db..c122daba42075e936f5fc4238ea98af9afc6c1da 100644

--- a/Source/bindings/scripts/unstable/v8_callback_interface.py

+++ b/Source/bindings/scripts/unstable/v8_callback_interface.py

@@ -53,7 +53,8 @@ CPP_TO_V8_CONVERSION = 'v8::Handle<v8::Value> {name}Handle = {cpp_value_to_v8_va

def cpp_to_v8_conversion(idl_type, name):

- this_cpp_value_to_v8_value = cpp_value_to_v8_value(idl_type, name, 'isolate', creation_context='v8::Handle<v8::Object>()')

+ # Includes handled in includes_for_operation

+ this_cpp_value_to_v8_value, _ = cpp_value_to_v8_value(idl_type, name, 'isolate', creation_context='v8::Handle<v8::Object>()')

return CPP_TO_V8_CONVERSION.format(name=name, cpp_value_to_v8_value=this_cpp_value_to_v8_value)