Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 2425693003: Revert of Linux build: Use sysroot when calculating dependencies (Closed)

Created:
4 years, 2 months ago by Tom (Use chromium acct)
Modified:
4 years, 2 months ago
Reviewers:
Dirk Pranke, brettw, Lei Zhang, Tom Anderson, open-source-third-party-reviews, security, Sam Clegg
CC:
chromium-reviews, grt+watch_chromium.org, pennymac+watch_chromium.org, Michael Moss, wfh+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Linux build: Use sysroot when calculating dependencies (patchset #7 id:120001 of https://codereview.chromium.org/2411423002/ ) Reason for revert: libdbus dependency issue http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%20x64/builds/14156 dpkg-shlibdeps.pl: warning: binaries to analyze should already be installed in their package's directory --- /b/c/b/Google_Chrome_Linux_x64/src/out/Release/installer/debian/expected_deps_x64_wheezy 2016-10-17 19:19:19.864623702 -0700 +++ actual 2016-10-17 20:14:30.636925109 -0700 @@ -4,7 +4,7 @@ libc6 (>= 2.11) libcairo2 (>= 1.6.0) libcups2 (>= 1.4.0) -libdbus-1-3 (>= 1.2.14) +libdbus-1-3 (>= 1.1.4) libexpat1 (>= 2.0.1) libfontconfig1 (>= 2.9.0) libfreetype6 (>= 2.3.9) Original issue's description: > Linux build: Use sysroot when calculating dependencies > > Additionally, this CL also bundles part of dpkg-shlibdeps. The version of dpkg-shlibdeps was too old on Precise to support the feature we needed for using the sysroot to calculate dependencies (specifically, the "-l" option was needed). This meant we needed to temporarily bundle a newer version dpkg-dev to get this working on Precise. > > Trusty has a newer version of dpkg-dev with the necessary feature, so dpkg-dev should be removed once the builders are entirely switch off of Precise. > > This can be done by reverting this CL and applying ps40001 from this CL. > > BUG=564904 > R=thestig@chromium.org,sbc@chromium.org,jochen@chromium.org > > Committed: https://crrev.com/0db721ca35ac387f5adf6bb9d7ec5ec24be4ac6e > Cr-Commit-Position: refs/heads/master@{#425842} TBR=thestig@chromium.org,sbc@chromium.org,dpranke@chromium.org,brettw@chromium.org,security@chromium.org,open-source-third-party-reviews@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=564904 Committed: https://crrev.com/7d200a1ddfeb50dbf9f7e2c1c4ff1080679edf02 Cr-Commit-Position: refs/heads/master@{#425887}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -18326 lines) Patch
M chrome/installer/linux/BUILD.gn View 3 chunks +4 lines, -9 lines 0 comments Download
M chrome/installer/linux/debian/build.sh View 6 chunks +29 lines, -39 lines 0 comments Download
D chrome/installer/linux/debian/expected_deps_ia32_jessie View 1 chunk +0 lines, -33 lines 0 comments Download
A chrome/installer/linux/debian/expected_deps_ia32_precise View 1 chunk +32 lines, -0 lines 0 comments Download
A chrome/installer/linux/debian/expected_deps_ia32_trusty View 1 chunk +33 lines, -0 lines 0 comments Download
D chrome/installer/linux/debian/expected_deps_ia32_wheezy View 1 chunk +0 lines, -33 lines 0 comments Download
D chrome/installer/linux/debian/expected_deps_x64_jessie View 1 chunk +0 lines, -32 lines 0 comments Download
A chrome/installer/linux/debian/expected_deps_x64_precise View 1 chunk +32 lines, -0 lines 0 comments Download
A chrome/installer/linux/debian/expected_deps_x64_trusty View 1 chunk +33 lines, -0 lines 0 comments Download
D chrome/installer/linux/debian/expected_deps_x64_wheezy View 1 chunk +0 lines, -32 lines 0 comments Download
D third_party/dpkg-dev/LICENSE View 1 chunk +0 lines, -339 lines 0 comments Download
D third_party/dpkg-dev/OWNERS View 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/dpkg-dev/README.chromium View 1 chunk +0 lines, -23 lines 0 comments Download
D third_party/dpkg-dev/abitable View 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/dpkg-dev/cputable View 1 chunk +0 lines, -42 lines 0 comments Download
D third_party/dpkg-dev/ostable View 1 chunk +0 lines, -38 lines 0 comments Download
D third_party/dpkg-dev/scripts/Dpkg.pm View 1 chunk +0 lines, -43 lines 0 comments Download
D third_party/dpkg-dev/scripts/Dpkg/Arch.pm View 1 chunk +0 lines, -445 lines 0 comments Download
D third_party/dpkg-dev/scripts/Dpkg/BuildEnv.pm View 1 chunk +0 lines, -107 lines 0 comments Download
D third_party/dpkg-dev/scripts/Dpkg/BuildFlags.pm View 1 chunk +0 lines, -456 lines 0 comments Download
D third_party/dpkg-dev/scripts/Dpkg/BuildOptions.pm View 1 chunk +0 lines, -204 lines 0 comments Download
D third_party/dpkg-dev/scripts/Dpkg/BuildProfiles.pm View 1 chunk +0 lines, -82 lines 0 comments Download
D third_party/dpkg-dev/scripts/Dpkg/Changelog.pm View 1 chunk +0 lines, -704 lines 0 comments Download
D third_party/dpkg-dev/scripts/Dpkg/Changelog/Debian.pm View 1 chunk +0 lines, -208 lines 0 comments Download
D third_party/dpkg-dev/scripts/Dpkg/Changelog/Entry.pm View 1 chunk +0 lines, -306 lines 0 comments Download
D third_party/dpkg-dev/scripts/Dpkg/Changelog/Entry/Debian.pm View 1 chunk +0 lines, -323 lines 0 comments Download
D third_party/dpkg-dev/scripts/Dpkg/Changelog/Parse.pm View 1 chunk +0 lines, -167 lines 0 comments Download
D third_party/dpkg-dev/scripts/Dpkg/Checksums.pm View 1 chunk +0 lines, -378 lines 0 comments Download
D third_party/dpkg-dev/scripts/Dpkg/Compression.pm View 1 chunk +0 lines, -244 lines 0 comments Download
D third_party/dpkg-dev/scripts/Dpkg/Compression/FileHandle.pm View 1 chunk +0 lines, -451 lines 0 comments Download
D third_party/dpkg-dev/scripts/Dpkg/Compression/Process.pm View 1 chunk +0 lines, -207 lines 0 comments Download
D third_party/dpkg-dev/scripts/Dpkg/Conf.pm View 1 chunk +0 lines, -184 lines 0 comments Download
D third_party/dpkg-dev/scripts/Dpkg/Control.pm View 1 chunk +0 lines, -200 lines 0 comments Download
D third_party/dpkg-dev/scripts/Dpkg/Control/Changelog.pm View 1 chunk +0 lines, -62 lines 0 comments Download
D third_party/dpkg-dev/scripts/Dpkg/Control/Fields.pm View 1 chunk +0 lines, -65 lines 0 comments Download
D third_party/dpkg-dev/scripts/Dpkg/Control/FieldsCore.pm View 1 chunk +0 lines, -660 lines 0 comments Download
D third_party/dpkg-dev/scripts/Dpkg/Control/Hash.pm View 1 chunk +0 lines, -46 lines 0 comments Download
D third_party/dpkg-dev/scripts/Dpkg/Control/HashCore.pm View 1 chunk +0 lines, -540 lines 0 comments Download
D third_party/dpkg-dev/scripts/Dpkg/Control/Info.pm View 1 chunk +0 lines, -209 lines 0 comments Download
D third_party/dpkg-dev/scripts/Dpkg/Control/Types.pm View 1 chunk +0 lines, -62 lines 0 comments Download
D third_party/dpkg-dev/scripts/Dpkg/Deps.pm View 1 chunk +0 lines, -1468 lines 0 comments Download
D third_party/dpkg-dev/scripts/Dpkg/ErrorHandling.pm View 1 chunk +0 lines, -107 lines 0 comments Download
D third_party/dpkg-dev/scripts/Dpkg/Exit.pm View 1 chunk +0 lines, -98 lines 0 comments Download
D third_party/dpkg-dev/scripts/Dpkg/File.pm View 1 chunk +0 lines, -60 lines 0 comments Download
D third_party/dpkg-dev/scripts/Dpkg/Gettext.pm View 1 chunk +0 lines, -66 lines 0 comments Download
D third_party/dpkg-dev/scripts/Dpkg/IPC.pm View 1 chunk +0 lines, -375 lines 0 comments Download
D third_party/dpkg-dev/scripts/Dpkg/Index.pm View 1 chunk +0 lines, -353 lines 0 comments Download
D third_party/dpkg-dev/scripts/Dpkg/Interface/Storable.pm View 1 chunk +0 lines, -147 lines 0 comments Download
D third_party/dpkg-dev/scripts/Dpkg/Package.pm View 1 chunk +0 lines, -45 lines 0 comments Download
D third_party/dpkg-dev/scripts/Dpkg/Path.pm View 1 chunk +0 lines, -295 lines 0 comments Download
D third_party/dpkg-dev/scripts/Dpkg/Shlibs.pm View 1 chunk +0 lines, -149 lines 0 comments Download
D third_party/dpkg-dev/scripts/Dpkg/Shlibs/Cppfilt.pm View 1 chunk +0 lines, -113 lines 0 comments Download
D third_party/dpkg-dev/scripts/Dpkg/Shlibs/Objdump.pm View 1 chunk +0 lines, -475 lines 0 comments Download
D third_party/dpkg-dev/scripts/Dpkg/Shlibs/Symbol.pm View 1 chunk +0 lines, -507 lines 0 comments Download
D third_party/dpkg-dev/scripts/Dpkg/Shlibs/SymbolFile.pm View 1 chunk +0 lines, -652 lines 0 comments Download
D third_party/dpkg-dev/scripts/Dpkg/Source/Archive.pm View 1 chunk +0 lines, -163 lines 0 comments Download
D third_party/dpkg-dev/scripts/Dpkg/Source/Functions.pm View 1 chunk +0 lines, -120 lines 0 comments Download
D third_party/dpkg-dev/scripts/Dpkg/Source/Package.pm View 1 chunk +0 lines, -631 lines 0 comments Download
D third_party/dpkg-dev/scripts/Dpkg/Source/Package/V1.pm View 1 chunk +0 lines, -402 lines 0 comments Download
D third_party/dpkg-dev/scripts/Dpkg/Source/Package/V2.pm View 1 chunk +0 lines, -767 lines 0 comments Download
D third_party/dpkg-dev/scripts/Dpkg/Source/Package/V3/Bzr.pm View 1 chunk +0 lines, -210 lines 0 comments Download
D third_party/dpkg-dev/scripts/Dpkg/Source/Package/V3/Custom.pm View 1 chunk +0 lines, -63 lines 0 comments Download
D third_party/dpkg-dev/scripts/Dpkg/Source/Package/V3/Git.pm View 1 chunk +0 lines, -235 lines 0 comments Download
D third_party/dpkg-dev/scripts/Dpkg/Source/Package/V3/Native.pm View 1 chunk +0 lines, -115 lines 0 comments Download
D third_party/dpkg-dev/scripts/Dpkg/Source/Package/V3/Quilt.pm View 1 chunk +0 lines, -291 lines 0 comments Download
D third_party/dpkg-dev/scripts/Dpkg/Source/Patch.pm View 1 chunk +0 lines, -640 lines 0 comments Download
D third_party/dpkg-dev/scripts/Dpkg/Source/Quilt.pm View 1 chunk +0 lines, -308 lines 0 comments Download
D third_party/dpkg-dev/scripts/Dpkg/Substvars.pm View 1 chunk +0 lines, -337 lines 0 comments Download
D third_party/dpkg-dev/scripts/Dpkg/Util.pm View 1 chunk +0 lines, -51 lines 0 comments Download
D third_party/dpkg-dev/scripts/Dpkg/Vars.pm View 1 chunk +0 lines, -50 lines 0 comments Download
D third_party/dpkg-dev/scripts/Dpkg/Vendor.pm View 1 chunk +0 lines, -182 lines 0 comments Download
D third_party/dpkg-dev/scripts/Dpkg/Vendor/Debian.pm View 1 chunk +0 lines, -194 lines 0 comments Download
D third_party/dpkg-dev/scripts/Dpkg/Vendor/Default.pm View 1 chunk +0 lines, -136 lines 0 comments Download
D third_party/dpkg-dev/scripts/Dpkg/Vendor/Ubuntu.pm View 1 chunk +0 lines, -185 lines 0 comments Download
D third_party/dpkg-dev/scripts/Dpkg/Version.pm View 1 chunk +0 lines, -445 lines 0 comments Download
D third_party/dpkg-dev/scripts/dpkg-shlibdeps.pl View 1 chunk +0 lines, -870 lines 0 comments Download
D third_party/dpkg-dev/triplettable View 1 chunk +0 lines, -31 lines 0 comments Download
M tools/checklicenses/checklicenses.py View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Tom (Use chromium acct)
Created Revert of Linux build: Use sysroot when calculating dependencies
4 years, 2 months ago (2016-10-18 04:06:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2425693003/1
4 years, 2 months ago (2016-10-18 04:06:38 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 2 months ago (2016-10-18 04:06:40 UTC) #5
Tom Anderson
lgtm from my @chromium account
4 years, 2 months ago (2016-10-18 04:07:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2425693003/1
4 years, 2 months ago (2016-10-18 04:08:21 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-18 04:10:37 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7d200a1ddfeb50dbf9f7e2c1c4ff1080679edf02 Cr-Commit-Position: refs/heads/master@{#425887}
4 years, 2 months ago (2016-10-18 04:13:29 UTC) #12
Lei Zhang
On 2016/10/18 04:07:57, Thomas Anderson wrote: > lgtm from my @chromium account Just revert from ...
4 years, 2 months ago (2016-10-18 04:14:33 UTC) #13
Dirk Pranke
4 years, 2 months ago (2016-10-18 16:23:11 UTC) #14
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698