Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Issue 2425693002: PRESUBMIT: rename trybots from gn to gyp. (Closed)

Created:
4 years, 2 months ago by kjellander_chromium
Modified:
4 years, 2 months ago
Reviewers:
fbarchard, fbarchard1
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

PRESUBMIT: rename trybots from gn to gyp. After switching the default bots from GYP to GN, we now only have a few GYP bots left, so rename the trybots accordingly BUG=chromium:652188 TBR=fbarchard@chromium.org Committed: https://chromium.googlesource.com/libyuv/libyuv/+/fcbb30f593021a4ff751c4c32d2c417a47c554dd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M PRESUBMIT.py View 3 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
kjellander_chromium
Committed patchset #1 (id:1) manually as fcbb30f593021a4ff751c4c32d2c417a47c554dd (presubmit successful).
4 years, 2 months ago (2016-10-17 13:10:01 UTC) #2
fbarchard1
looks like this breaks the bots. will need a followup to fix
4 years, 2 months ago (2016-10-17 17:00:50 UTC) #4
kjellander_chromium
4 years, 2 months ago (2016-10-18 06:18:12 UTC) #5
Message was sent while issue was closed.
On 2016/10/17 17:00:50, fbarchard1 wrote:
> looks like this breaks the bots.  will need a followup to fix

I don't think this particular change is breaking the bots, but there's been a
few problems with old build artifacts from GYP that causes an error when running
GN. I was trying to clear them out with landmines but it doesn't seem to be
working as intended yet.

Powered by Google App Engine
This is Rietveld 408576698