Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2425683006: Relax '*' in CSPSourceList to match the FTP protocol. (Closed)

Created:
4 years, 2 months ago by elawrence
Modified:
4 years, 2 months ago
Reviewers:
*Mike West
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Relax '*' in CSPSourceList to match the FTP protocol. '*' should match 'ftp://whatever/file.pdf' because 'ftp' is a network scheme under the CSP specification. BUG=656956 Committed: https://crrev.com/79209ba0cefc48a9fdedf602658e84ddf9b8879b Cr-Commit-Position: refs/heads/master@{#426069}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M third_party/WebKit/Source/core/frame/csp/CSPSourceList.cpp View 1 chunk +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/frame/csp/CSPSourceListTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
elawrence
PTAL? Thanks!
4 years, 2 months ago (2016-10-18 19:01:02 UTC) #3
Mike West
LGTM. Thank you for putting this together so quickly.
4 years, 2 months ago (2016-10-18 19:25:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2425683006/1
4 years, 2 months ago (2016-10-18 21:34:28 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-18 22:14:10 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:03:59 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/79209ba0cefc48a9fdedf602658e84ddf9b8879b
Cr-Commit-Position: refs/heads/master@{#426069}

Powered by Google App Engine
This is Rietveld 408576698