Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2425683004: Rename policy ReportArcStatus to ReportArcStatusEnabled (Closed)

Created:
4 years, 2 months ago by phweiss
Modified:
4 years, 2 months ago
Reviewers:
Thiemo Nagel
CC:
chromium-reviews, tnagel+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename policy ReportArcStatus to ReportArcStatusEnabled for consistency with other boolean policies. BUG=654431 Committed: https://crrev.com/f62f4b50cfdecbede2ba427719906b84d93e1dd9 Cr-Commit-Position: refs/heads/master@{#425943}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -14 lines) Patch
M chrome/browser/chromeos/policy/device_status_collector.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/policy/device_status_collector_browsertest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/policy/configuration_policy_handler_list_factory.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/pref_names.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +1 line, -1 line 1 comment Download
M chrome/test/data/policy/policy_test_cases.json View 1 chunk +3 lines, -3 lines 0 comments Download
M components/policy/resources/policy_templates.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
phweiss
ptal
4 years, 2 months ago (2016-10-18 10:09:16 UTC) #4
phweiss
ptal
4 years, 2 months ago (2016-10-18 10:09:21 UTC) #5
Thiemo Nagel
lgtm with nits https://codereview.chromium.org/2425683004/diff/1/chrome/common/pref_names.cc File chrome/common/pref_names.cc (right): https://codereview.chromium.org/2425683004/diff/1/chrome/common/pref_names.cc#newcode1859 chrome/common/pref_names.cc:1859: // A preference that controlles Android ...
4 years, 2 months ago (2016-10-18 10:12:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2425683004/1
4 years, 2 months ago (2016-10-18 12:10:35 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-18 12:14:45 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-18 12:17:32 UTC) #13
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f62f4b50cfdecbede2ba427719906b84d93e1dd9
Cr-Commit-Position: refs/heads/master@{#425943}

Powered by Google App Engine
This is Rietveld 408576698