Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1811)

Unified Diff: content/shell/browser/shell_devtools_frontend.cc

Issue 2425673006: Make URLFetcherFileWriter::Finish() skip closing file when there is an error (Closed)
Patch Set: Fix test Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/precache/core/precache_fetcher.cc ('k') | google_apis/drive/base_requests.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/shell/browser/shell_devtools_frontend.cc
diff --git a/content/shell/browser/shell_devtools_frontend.cc b/content/shell/browser/shell_devtools_frontend.cc
index 968a2427c51b474138e9cacb4a61ca63bb324bb6..6a81d71c7957a13b3bef481d59302ee1e837e3e4 100644
--- a/content/shell/browser/shell_devtools_frontend.cc
+++ b/content/shell/browser/shell_devtools_frontend.cc
@@ -49,7 +49,7 @@ class ResponseWriter : public net::URLFetcherResponseWriter {
int Write(net::IOBuffer* buffer,
int num_bytes,
const net::CompletionCallback& callback) override;
- int Finish(const net::CompletionCallback& callback) override;
+ int Finish(int net_error, const net::CompletionCallback& callback) override;
private:
base::WeakPtr<ShellDevToolsFrontend> shell_devtools_;
@@ -90,7 +90,8 @@ int ResponseWriter::Write(net::IOBuffer* buffer,
return num_bytes;
}
-int ResponseWriter::Finish(const net::CompletionCallback& callback) {
+int ResponseWriter::Finish(int net_error,
+ const net::CompletionCallback& callback) {
return net::OK;
}
« no previous file with comments | « components/precache/core/precache_fetcher.cc ('k') | google_apis/drive/base_requests.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698