third_party/libaddressinput/chromium/chrome_metadata_source.cc - Issue 2425673006: Make URLFetcherFileWriter::Finish() skip closing file when there is an error

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/libaddressinput/chromium/chrome_metadata_source.cc

Issue 2425673006: Make URLFetcherFileWriter::Finish() skip closing file when there is an error (Closed)

Patch Set: Fix another subclass Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/libaddressinput/chromium/chrome_metadata_source.cc

diff --git a/third_party/libaddressinput/chromium/chrome_metadata_source.cc b/third_party/libaddressinput/chromium/chrome_metadata_source.cc

index af0dde25579b9b0c3121012d8d31854d4fb6b58a..b875b51da71031a0865f6b78fdd967fe3dfdb60e 100644

--- a/third_party/libaddressinput/chromium/chrome_metadata_source.cc

+++ b/third_party/libaddressinput/chromium/chrome_metadata_source.cc

@@ -40,7 +40,8 @@ class UnownedStringWriter : public net::URLFetcherResponseWriter {

return num_bytes;

}

- virtual int Finish(const net::CompletionCallback& callback) override {

+ virtual int Finish(int net_error,

+ const net::CompletionCallback& callback) override {

return net::OK;

}