google_apis/drive/base_requests.h - Issue 2425673006: Make URLFetcherFileWriter::Finish() skip closing file when there is an error

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: google_apis/drive/base_requests.h

Issue 2425673006: Make URLFetcherFileWriter::Finish() skip closing file when there is an error (Closed)

Patch Set: Fix another subclass Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: google_apis/drive/base_requests.h

diff --git a/google_apis/drive/base_requests.h b/google_apis/drive/base_requests.h

index 78c641b128b80351c2b67ab8439ed241ed3a1039..c4e2a2eeadd53b2c3d133a6b69bc7d54ad113f9e 100644

--- a/google_apis/drive/base_requests.h

+++ b/google_apis/drive/base_requests.h

@@ -135,7 +135,7 @@ class ResponseWriter : public net::URLFetcherResponseWriter {

int Write(net::IOBuffer* buffer,

int num_bytes,

const net::CompletionCallback& callback) override;

- int Finish(const net::CompletionCallback& callback) override;

+ int Finish(int net_error, const net::CompletionCallback& callback) override;

private:

void DidWrite(scoped_refptr<net::IOBuffer> buffer,