components/sync/base/pref_names.h - Issue 2425673003: [Sync] Moved down comments directly following copyright.

Side by Side Diff: components/sync/base/pref_names.h

Issue 2425673003: [Sync] Moved down comments directly following copyright. (Closed)

Patch Set: Rebase and removing TODO about exporting. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« components/sync/base/model_type.h ('K') | « components/sync/base/model_type.h ('k') | components/sync/base/progress_marker_map.h » ('j') | components/sync/engine_impl/all_status.h » ('J')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // Constants for the names of various sync preferences, for easier changing.

6

7 #ifndef COMPONENTS_SYNC_BASE_PREF_NAMES_H_	5 #ifndef COMPONENTS_SYNC_BASE_PREF_NAMES_H_

8 #define COMPONENTS_SYNC_BASE_PREF_NAMES_H_	6 #define COMPONENTS_SYNC_BASE_PREF_NAMES_H_

9	7

10 #include "build/build_config.h"	8 #include "build/build_config.h"

11	9

12 namespace syncer {	10 namespace syncer {

13	11

14 namespace prefs {	12 namespace prefs {

15	13

	14 // Constants for the names of various sync preferences, for easier changing.
	maxbogue 2016/10/17 23:59:46 This comment is ironic since changing a preference This comment is ironic since changing a preference value isn't really something we can do (you lose the old value, right?). But it's fine to leave it. Also this could probably just live right above the namespace prefs { line? But either way. skym 2016/10/18 14:39:08 Haha, you make a great point about them not really Show quoted text On 2016/10/17 23:59:46, maxbogue wrote: > This comment is ironic since changing a preference value isn't really something > we can do (you lose the old value, right?). But it's fine to leave it. > > Also this could probably just live right above the namespace prefs { line? But > either way. Haha, you make a great point about them not really being change-able. I'm just going to remove this comment, it's not really adding value.
	15

16 extern const char kSyncLastSyncedTime[];	16 extern const char kSyncLastSyncedTime[];

17 extern const char kSyncLastPollTime[];	17 extern const char kSyncLastPollTime[];

18 extern const char kSyncHasAuthError[];	18 extern const char kSyncHasAuthError[];

19 extern const char kSyncFirstSetupComplete[];	19 extern const char kSyncFirstSetupComplete[];

20 extern const char kSyncKeepEverythingSynced[];	20 extern const char kSyncKeepEverythingSynced[];

21	21

22 extern const char kSyncAppList[];	22 extern const char kSyncAppList[];

23 extern const char kSyncAppNotifications[];	23 extern const char kSyncAppNotifications[];

24 extern const char kSyncAppSettings[];	24 extern const char kSyncAppSettings[];

25 extern const char kSyncApps[];	25 extern const char kSyncApps[];

(...skipping 53 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
79 extern const char kSyncLastRunVersion[];	79 extern const char kSyncLastRunVersion[];

80	80

81 extern const char kSyncPassphraseEncryptionTransitionInProgress[];	81 extern const char kSyncPassphraseEncryptionTransitionInProgress[];

82 extern const char kSyncNigoriStateForPassphraseTransition[];	82 extern const char kSyncNigoriStateForPassphraseTransition[];

83	83

84 } // namespace prefs	84 } // namespace prefs

85	85

86 } // namespace syncer	86 } // namespace syncer

87	87

88 #endif // COMPONENTS_SYNC_BASE_PREF_NAMES_H_	88 #endif // COMPONENTS_SYNC_BASE_PREF_NAMES_H_

OLD	NEW