media: Use native CDM enum types in media mojo interfaces

media: Use native CDM enum types in media mojo interfaces

Also:
- Removed obsolete CDM IPC messages (see issue 581746)
- Fixed some places missed in previsou CLs

TBR=jam@chromium.org
BUG=417440, 581746, 611224
TEST=mojo_media_unittests still pass

Committed: https://crrev.com/322c301a32ac10c6d374434e2642798ccf6c7bdb
Cr-Commit-Position: refs/heads/master@{#425850}

[xhwang, 2016-10-17 19:21:10]

The CQ bit was checked by xhwang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-17 19:21:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-17 19:25:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-17 19:25:47]

Dry run: Exceeded global retry quota

[xhwang, 2016-10-17 19:44:45]

rebase only

[xhwang, 2016-10-17 21:48:04]

xhwang@chromium.org changed reviewers:
+ dcheng@chromium.org, jrummell@chromium.org

[xhwang, 2016-10-17 21:48:04]

The last one to convert Enums. Next I'll look into structs.

PTAL

[dcheng, 2016-10-17 23:05:22]

lgtm

https://codereview.chromium.org/2425663003/diff/40001/media/base/eme_constants.h
File media/base/eme_constants.h (right):

https://codereview.chromium.org/2425663003/diff/40001/media/base/eme_constant...
media/base/eme_constants.h:22: EME_INIT_DATA_TYPE_MAX = KEYIDS
Nit: MAX here should be good enough? UNless it's conflicting with something like
MAX from the windows SDK?

[xhwang, 2016-10-17 23:22:18]

https://codereview.chromium.org/2425663003/diff/40001/media/base/eme_constants.h
File media/base/eme_constants.h (right):

https://codereview.chromium.org/2425663003/diff/40001/media/base/eme_constant...
media/base/eme_constants.h:22: EME_INIT_DATA_TYPE_MAX = KEYIDS
On 2016/10/17 23:05:22, dcheng wrote:
> Nit: MAX here should be good enough? UNless it's conflicting with something
like
> MAX from the windows SDK?

I didn't try it since I don't always have a windows checkout but this scared me:

http://stackoverflow.com/questions/11544073/how-do-i-deal-with-the-max-macro-...

So I'd like to keep it as is unless you have a strong opinion.

[xhwang, 2016-10-17 23:22:28]

The CQ bit was checked by xhwang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-17 23:23:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dcheng, 2016-10-17 23:26:02]

https://codereview.chromium.org/2425663003/diff/40001/media/base/eme_constants.h
File media/base/eme_constants.h (right):

https://codereview.chromium.org/2425663003/diff/40001/media/base/eme_constant...
media/base/eme_constants.h:22: EME_INIT_DATA_TYPE_MAX = KEYIDS
On 2016/10/17 23:22:18, xhwang wrote:
> On 2016/10/17 23:05:22, dcheng wrote:
> > Nit: MAX here should be good enough? UNless it's conflicting with something
> like
> > MAX from the windows SDK?
> 
> I didn't try it since I don't always have a windows checkout but this scared
me:
> 
>
http://stackoverflow.com/questions/11544073/how-do-i-deal-with-the-max-macro-...
> 
> So I'd like to keep it as is unless you have a strong opinion.

Our default build config sets NOMINMAX:
https://cs.chromium.org/chromium/src/build/config/BUILDCONFIG.gn?rcl=0&l=484

[xhwang, 2016-10-17 23:29:38]

On 2016/10/17 23:26:02, dcheng wrote:
>
https://codereview.chromium.org/2425663003/diff/40001/media/base/eme_constants.h
> File media/base/eme_constants.h (right):
> 
>
https://codereview.chromium.org/2425663003/diff/40001/media/base/eme_constant...
> media/base/eme_constants.h:22: EME_INIT_DATA_TYPE_MAX = KEYIDS
> On 2016/10/17 23:22:18, xhwang wrote:
> > On 2016/10/17 23:05:22, dcheng wrote:
> > > Nit: MAX here should be good enough? UNless it's conflicting with
something
> > like
> > > MAX from the windows SDK?
> > 
> > I didn't try it since I don't always have a windows checkout but this scared
> me:
> > 
> >
>
http://stackoverflow.com/questions/11544073/how-do-i-deal-with-the-max-macro-...
> > 
> > So I'd like to keep it as is unless you have a strong opinion.
> 
> Our default build config sets NOMINMAX:
> https://cs.chromium.org/chromium/src/build/config/BUILDCONFIG.gn?rcl=0&l=484

Fair enough and thanks! I'll change it.

[xhwang, 2016-10-17 23:35:01]

comments addressed

[xhwang, 2016-10-17 23:35:06]

The CQ bit was checked by xhwang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-17 23:35:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jrummell, 2016-10-17 23:47:25]

LGTM w/nits.

(also s/previsou/previous in CL description)

https://codereview.chromium.org/2425663003/diff/60001/media/mojo/interfaces/c...
File media/mojo/interfaces/content_decryption_module.mojom (right):

https://codereview.chromium.org/2425663003/diff/60001/media/mojo/interfaces/c...
media/mojo/interfaces/content_decryption_module.mojom:12: enum EmeInitDataType;
I'm curious why this is outside interface ContentDecryptionModule.

https://codereview.chromium.org/2425663003/diff/60001/media/mojo/interfaces/c...
media/mojo/interfaces/content_decryption_module.mojom:16: // of a specific key
ID.
I think this comment should be deleted.

[xhwang, 2016-10-17 23:51:05]

comments addressed

[xhwang, 2016-10-17 23:51:11]

The CQ bit was checked by xhwang@chromium.org to run a CQ dry run

[xhwang, 2016-10-17 23:51:14]

https://codereview.chromium.org/2425663003/diff/60001/media/mojo/interfaces/c...
File media/mojo/interfaces/content_decryption_module.mojom (right):

https://codereview.chromium.org/2425663003/diff/60001/media/mojo/interfaces/c...
media/mojo/interfaces/content_decryption_module.mojom:12: enum EmeInitDataType;
On 2016/10/17 23:47:24, jrummell wrote:
> I'm curious why this is outside interface ContentDecryptionModule.

Because the C++ media::EmeInitDataType is declared out of MediaKeys. It's also
used in demuxer code for the encrypted() event. I am trying to make the mojo
layer consistent with the C++ layer.

https://codereview.chromium.org/2425663003/diff/60001/media/mojo/interfaces/c...
media/mojo/interfaces/content_decryption_module.mojom:16: // of a specific key
ID.
On 2016/10/17 23:47:24, jrummell wrote:
> I think this comment should be deleted.

oops, thanks for catching that

done

[commit-bot: I haz the power, 2016-10-17 23:52:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xhwang, 2016-10-18 00:22:45]

The CQ bit was unchecked by xhwang@chromium.org

[xhwang, 2016-10-18 00:22:47]

The CQ bit was checked by xhwang@chromium.org

[xhwang, 2016-10-18 00:22:48]

The patchset sent to the CQ was uploaded after l-g-t-m from dcheng@chromium.org,
jrummell@chromium.org
Link to the patchset: https://codereview.chromium.org/2425663003/#ps80001
(title: "comments addressed")

[xhwang, 2016-10-18 00:22:57]

The CQ bit was checked by xhwang@chromium.org

[commit-bot: I haz the power, 2016-10-18 00:23:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-18 00:28:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-18 00:28:37]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[xhwang, 2016-10-18 01:01:58]

Description was changed from

==========
media: Use native CDM enum types in media mojo interfaces

Also:
- Removed obsolete CDM IPC messages (see issue 581746)
- Fixed some places missed in previsou CLs

BUG=417440,581746,611224
TEST=mojo_media_unittests still pass
==========

to

==========
media: Use native CDM enum types in media mojo interfaces

Also:
- Removed obsolete CDM IPC messages (see issue 581746)
- Fixed some places missed in previsou CLs

TBR=jam@chromium.org
BUG=417440,581746,611224
TEST=mojo_media_unittests still pass
==========

[xhwang, 2016-10-18 01:01:58]

xhwang@chromium.org changed reviewers:
+ jam@chromium.org

[xhwang, 2016-10-18 01:02:33]

TBRing jam@ for trivial changes in content/common/* where I removed obsolete IPC
messages.

[xhwang, 2016-10-18 01:02:39]

The CQ bit was checked by xhwang@chromium.org

[commit-bot: I haz the power, 2016-10-18 01:03:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-18 01:42:45]

Description was changed from

==========
media: Use native CDM enum types in media mojo interfaces

Also:
- Removed obsolete CDM IPC messages (see issue 581746)
- Fixed some places missed in previsou CLs

TBR=jam@chromium.org
BUG=417440,581746,611224
TEST=mojo_media_unittests still pass
==========

to

==========
media: Use native CDM enum types in media mojo interfaces

Also:
- Removed obsolete CDM IPC messages (see issue 581746)
- Fixed some places missed in previsou CLs

TBR=jam@chromium.org
BUG=417440,581746,611224
TEST=mojo_media_unittests still pass
==========

[commit-bot: I haz the power, 2016-10-18 01:42:47]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-10-18 01:45:39]

Description was changed from

==========
media: Use native CDM enum types in media mojo interfaces

Also:
- Removed obsolete CDM IPC messages (see issue 581746)
- Fixed some places missed in previsou CLs

TBR=jam@chromium.org
BUG=417440,581746,611224
TEST=mojo_media_unittests still pass
==========

to

==========
media: Use native CDM enum types in media mojo interfaces

Also:
- Removed obsolete CDM IPC messages (see issue 581746)
- Fixed some places missed in previsou CLs

TBR=jam@chromium.org
BUG=417440,581746,611224
TEST=mojo_media_unittests still pass

Committed: https://crrev.com/322c301a32ac10c6d374434e2642798ccf6c7bdb
Cr-Commit-Position: refs/heads/master@{#425850}
==========

[commit-bot: I haz the power, 2016-10-18 01:45:41]

Patchset 5 (id:??) landed as
https://crrev.com/322c301a32ac10c6d374434e2642798ccf6c7bdb
Cr-Commit-Position: refs/heads/master@{#425850}