Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2425633002: Separate scope info allocation for the debugger from regular allocation (Closed)

Created:
4 years, 2 months ago by Toon Verwaest
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Separate scope info allocation for the debugger from regular allocation BUG= Committed: https://crrev.com/b7a163257b3fcfa2c10e66b4ee7f39845fe34192 Cr-Commit-Position: refs/heads/master@{#40349}

Patch Set 1 #

Patch Set 2 : Restore allocation of function scope infos #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -18 lines) Patch
M src/ast/scopes.h View 1 1 chunk +3 lines, -1 line 0 comments Download
M src/ast/scopes.cc View 1 3 chunks +28 lines, -17 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Toon Verwaest
ptal
4 years, 2 months ago (2016-10-17 09:01:19 UTC) #3
jochen (gone - plz use gerrit)
lgtm
4 years, 2 months ago (2016-10-17 09:04:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2425633002/40001
4 years, 2 months ago (2016-10-17 09:20:38 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 2 months ago (2016-10-17 09:44:48 UTC) #7
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 09:45:12 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b7a163257b3fcfa2c10e66b4ee7f39845fe34192
Cr-Commit-Position: refs/heads/master@{#40349}

Powered by Google App Engine
This is Rietveld 408576698