Chromium Code Reviews
DescriptionRevert of Fix <object data=> YouTube Flash rewrites. (patchset #1 id:1 of https://codereview.chromium.org/2416253002/ )
Reason for revert:
This CL appears to be causing failures on ChromiumOS:
https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/19066
browser_tests on Ubuntu-12.04 browser_tests on Ubuntu-12.04
678 disabled
10 flaky
failed 1
failures:
ChromeContentRendererClientBrowserTest.RewriteYouTubeFlashEmbed
Original issue's description:
> Fix <object data=> YouTube Flash rewrites.
>
> Some YouTube videos are embedded via <object data="http://www.youtube.com/v/AABBCCDD">.
> Chrome currently only rewrites embeds that use <embed src="http://www.youtube.com/v/AABBCCDD">
> The CL adds the logic for rewriting YouTube Flash plugin embed URLs with HTML5 embeds to the
> HTMLObjectElement (this matches Firefox behavior).
>
> BUG=655988
> TEST=manual + updated browser tests
>
> Committed: https://crrev.com/d5ee1a98ea763ab6231e71ffa03f55290a20c837
> Cr-Commit-Position: refs/heads/master@{#425704}
TBR=jochen@chromium.org,foolip@chromium.org,mlamouri@chromium.org,avayvod@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=655988
Committed: https://crrev.com/bf84ffa9ddc686758aeb218e2ed68c446dc944eb
Cr-Commit-Position: refs/heads/master@{#425771}
Patch Set 1 #
Messages
Total messages: 7 (3 generated)
|
|||||||||||||||||||||||||||||||||||||