Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2425623003: Revert of Fix <object data=> YouTube Flash rewrites. (Closed)

Created:
4 years, 2 months ago by joedow
Modified:
4 years, 2 months ago
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix <object data=> YouTube Flash rewrites. (patchset #1 id:1 of https://codereview.chromium.org/2416253002/ ) Reason for revert: This CL appears to be causing failures on ChromiumOS: https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/19066 browser_tests on Ubuntu-12.04 browser_tests on Ubuntu-12.04 678 disabled 10 flaky failed 1 failures: ChromeContentRendererClientBrowserTest.RewriteYouTubeFlashEmbed Original issue's description: > Fix <object data=> YouTube Flash rewrites. > > Some YouTube videos are embedded via <object data="http://www.youtube.com/v/AABBCCDD">. > Chrome currently only rewrites embeds that use <embed src="http://www.youtube.com/v/AABBCCDD"> > The CL adds the logic for rewriting YouTube Flash plugin embed URLs with HTML5 embeds to the > HTMLObjectElement (this matches Firefox behavior). > > BUG=655988 > TEST=manual + updated browser tests > > Committed: https://crrev.com/d5ee1a98ea763ab6231e71ffa03f55290a20c837 > Cr-Commit-Position: refs/heads/master@{#425704} TBR=jochen@chromium.org,foolip@chromium.org,mlamouri@chromium.org,avayvod@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=655988 Committed: https://crrev.com/bf84ffa9ddc686758aeb218e2ed68c446dc944eb Cr-Commit-Position: refs/heads/master@{#425771}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -87 lines) Patch
M chrome/renderer/chrome_content_renderer_client_browsertest.cc View 4 chunks +38 lines, -68 lines 0 comments Download
M chrome/test/data/flash_embeds.html View 2 chunks +1 line, -8 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLObjectElement.cpp View 2 chunks +0 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
joedow
Created Revert of Fix <object data=> YouTube Flash rewrites.
4 years, 2 months ago (2016-10-17 20:45:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2425623003/1
4 years, 2 months ago (2016-10-17 20:45:55 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-17 20:47:04 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 20:49:03 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bf84ffa9ddc686758aeb218e2ed68c446dc944eb
Cr-Commit-Position: refs/heads/master@{#425771}

Powered by Google App Engine
This is Rietveld 408576698