Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Unified Diff: third_party/WebKit/Source/core/editing/VisibleSelection.cpp

Issue 2425623002: Get rid of flat tree version of createVisibleSelection() taking two VisiblePositionInFlatTree (Closed)
Patch Set: 2016-10-18T17:29:55 Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/VisibleSelection.cpp
diff --git a/third_party/WebKit/Source/core/editing/VisibleSelection.cpp b/third_party/WebKit/Source/core/editing/VisibleSelection.cpp
index acc3e6ab9ddc781a624adc7a1523d647a044ab4e..ed0896a02cd6952e2489d7e194a921f18686f5ee 100644
--- a/third_party/WebKit/Source/core/editing/VisibleSelection.cpp
+++ b/third_party/WebKit/Source/core/editing/VisibleSelection.cpp
@@ -159,18 +159,6 @@ VisibleSelectionInFlatTree createVisibleSelection(
}
VisibleSelectionInFlatTree createVisibleSelection(
- const VisiblePositionInFlatTree& base,
- const VisiblePositionInFlatTree& extent,
- bool isDirectional) {
- DCHECK(base.isValid());
- DCHECK(extent.isValid());
- // TODO(xiaochengh): We should check |base.isNotNull() || extent.isNull()|
- // after all call sites have ensured that.
- return createVisibleSelection(base.deepEquivalent(), extent.deepEquivalent(),
- base.affinity(), isDirectional);
-}
-
-VisibleSelectionInFlatTree createVisibleSelection(
const EphemeralRangeInFlatTree& range,
TextAffinity affinity,
bool isDirectional) {

Powered by Google App Engine
This is Rietveld 408576698