Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Side by Side Diff: third_party/WebKit/Source/core/editing/VisibleSelection.h

Issue 2425623002: Get rid of flat tree version of createVisibleSelection() taking two VisiblePositionInFlatTree (Closed)
Patch Set: 2016-10-18T17:29:55 Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004 Apple Computer, Inc. All rights reserved. 2 * Copyright (C) 2004 Apple Computer, Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 230 matching lines...) Expand 10 before | Expand all | Expand 10 after
241 const PositionInFlatTree& extent, 241 const PositionInFlatTree& extent,
242 TextAffinity = SelDefaultAffinity, 242 TextAffinity = SelDefaultAffinity,
243 bool isDirectional = false); 243 bool isDirectional = false);
244 CORE_EXPORT VisibleSelectionInFlatTree 244 CORE_EXPORT VisibleSelectionInFlatTree
245 createVisibleSelection(const EphemeralRangeInFlatTree&, 245 createVisibleSelection(const EphemeralRangeInFlatTree&,
246 TextAffinity = SelDefaultAffinity, 246 TextAffinity = SelDefaultAffinity,
247 bool isDirectional = false); 247 bool isDirectional = false);
248 CORE_EXPORT VisibleSelectionInFlatTree 248 CORE_EXPORT VisibleSelectionInFlatTree
249 createVisibleSelection(const VisiblePositionInFlatTree&, 249 createVisibleSelection(const VisiblePositionInFlatTree&,
250 bool isDirectional = false); 250 bool isDirectional = false);
251 CORE_EXPORT VisibleSelectionInFlatTree
252 createVisibleSelection(const VisiblePositionInFlatTree&,
253 const VisiblePositionInFlatTree&,
254 bool isDirectional = false);
255 251
256 // We don't yet support multi-range selections, so we only ever have one range 252 // We don't yet support multi-range selections, so we only ever have one range
257 // to return. 253 // to return.
258 CORE_EXPORT EphemeralRange firstEphemeralRangeOf(const VisibleSelection&); 254 CORE_EXPORT EphemeralRange firstEphemeralRangeOf(const VisibleSelection&);
259 255
260 // TODO(sof): move more firstRangeOf() uses to be over EphemeralRange instead. 256 // TODO(sof): move more firstRangeOf() uses to be over EphemeralRange instead.
261 CORE_EXPORT Range* firstRangeOf(const VisibleSelection&); 257 CORE_EXPORT Range* firstRangeOf(const VisibleSelection&);
262 258
263 CORE_EXPORT std::ostream& operator<<(std::ostream&, const VisibleSelection&); 259 CORE_EXPORT std::ostream& operator<<(std::ostream&, const VisibleSelection&);
264 CORE_EXPORT std::ostream& operator<<(std::ostream&, 260 CORE_EXPORT std::ostream& operator<<(std::ostream&,
265 const VisibleSelectionInFlatTree&); 261 const VisibleSelectionInFlatTree&);
266 262
267 } // namespace blink 263 } // namespace blink
268 264
269 #ifndef NDEBUG 265 #ifndef NDEBUG
270 // Outside the WebCore namespace for ease of invocation from gdb. 266 // Outside the WebCore namespace for ease of invocation from gdb.
271 void showTree(const blink::VisibleSelection&); 267 void showTree(const blink::VisibleSelection&);
272 void showTree(const blink::VisibleSelection*); 268 void showTree(const blink::VisibleSelection*);
273 void showTree(const blink::VisibleSelectionInFlatTree&); 269 void showTree(const blink::VisibleSelectionInFlatTree&);
274 void showTree(const blink::VisibleSelectionInFlatTree*); 270 void showTree(const blink::VisibleSelectionInFlatTree*);
275 #endif 271 #endif
276 272
277 #endif // VisibleSelection_h 273 #endif // VisibleSelection_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698