Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 2425613002: [turbofan] Eliminate CheckHeapObject if the input cannot be in SignedSmall range. (Closed)

Created:
4 years, 2 months ago by Benedikt Meurer
Modified:
4 years, 2 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Eliminate CheckHeapObject if the input cannot be in SignedSmall range. R=jarin@chromium.org Committed: https://crrev.com/a40be67bbdc4e69f6cf613ba4fdd21108d5ae524 Cr-Commit-Position: refs/heads/master@{#40339}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M src/compiler/typed-optimization.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/typed-optimization.cc View 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Benedikt Meurer
4 years, 2 months ago (2016-10-17 07:46:24 UTC) #1
Jarin
lgtm
4 years, 2 months ago (2016-10-17 08:22:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2425613002/1
4 years, 2 months ago (2016-10-17 08:23:14 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-17 08:36:23 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 08:36:43 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a40be67bbdc4e69f6cf613ba4fdd21108d5ae524
Cr-Commit-Position: refs/heads/master@{#40339}

Powered by Google App Engine
This is Rietveld 408576698