Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2425593002: Remove DCHECK in BreakingContextInlineHeader that wasn't much useful (Closed)

Created:
4 years, 2 months ago by kojii
Modified:
4 years, 2 months ago
Reviewers:
eae
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove DCHECK in BreakingContextInlineHeader that wasn't much useful Originally thought this failure can lead to layout failures, but as we understand failing cases, its failure does not look to cause any real problems. BUG=655067 Committed: https://crrev.com/7063f99d4a6ae1b57d47d012b4e53c57f25187d6 Cr-Commit-Position: refs/heads/master@{#425845}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M third_party/WebKit/Source/core/layout/line/BreakingContextInlineHeaders.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
kojii
PTAL.
4 years, 2 months ago (2016-10-17 06:14:27 UTC) #6
eae
Thank you, LGTM
4 years, 2 months ago (2016-10-17 16:54:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2425593002/1
4 years, 2 months ago (2016-10-18 01:15:35 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-18 01:20:52 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-18 01:23:18 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7063f99d4a6ae1b57d47d012b4e53c57f25187d6
Cr-Commit-Position: refs/heads/master@{#425845}

Powered by Google App Engine
This is Rietveld 408576698