Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2425563004: Support reading multiple InterfaceProviderSpecs from manifests (Closed)

Created:
4 years, 2 months ago by Ben Goodger (Google)
Modified:
4 years, 1 month ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Support reading multiple InterfaceProviderSpecs from manifests. Wires the specs thru the ServiceManager to clients. Doesn't do anything interesting with them yet (i.e. doesn't pass them thru service_manager::Service). Hence no tests. That'll come next since I don't want to update all Service impls in this CL. R=rockot@chromium.org,tsepez@chromium.org Committed: https://crrev.com/cd6411161764cae700abf1699c10ecbdb2c54a39 Cr-Commit-Position: refs/heads/master@{#427299}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : . #

Patch Set 7 : . #

Patch Set 8 : . #

Patch Set 9 : . #

Patch Set 10 : . #

Patch Set 11 : . #

Patch Set 12 : . #

Patch Set 13 : . #

Patch Set 14 : . #

Patch Set 15 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+272 lines, -125 lines) Patch
M mash/app_driver/app_driver.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M mash/quick_launch/quick_launch.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M mash/task_viewer/task_viewer.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M services/catalog/entry.h View 1 2 3 chunks +8 lines, -9 lines 0 comments Download
M services/catalog/entry.cc View 1 2 3 4 5 6 7 4 chunks +48 lines, -38 lines 0 comments Download
M services/catalog/entry_unittest.cc View 1 2 3 4 5 6 1 chunk +3 lines, -1 line 0 comments Download
M services/catalog/instance.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M services/catalog/instance.cc View 1 11 2 chunks +4 lines, -5 lines 0 comments Download
M services/catalog/public/interfaces/catalog.mojom View 1 1 chunk +2 lines, -2 lines 0 comments Download
M services/catalog/store.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M services/catalog/store.cc View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M services/service_manager/public/cpp/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M services/service_manager/public/cpp/interface_provider_spec.h View 2 chunks +5 lines, -0 lines 0 comments Download
M services/service_manager/public/cpp/lib/service_context.cc View 1 2 chunks +6 lines, -6 lines 0 comments Download
A services/service_manager/public/cpp/lib/service_info.cc View 1 1 chunk +17 lines, -0 lines 0 comments Download
M services/service_manager/public/cpp/service_context.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
A services/service_manager/public/cpp/service_info.h View 1 1 chunk +30 lines, -0 lines 0 comments Download
A services/service_manager/public/cpp/service_info.typemap View 1 1 chunk +11 lines, -0 lines 0 comments Download
A services/service_manager/public/cpp/service_info_struct_traits.h View 1 1 chunk +33 lines, -0 lines 0 comments Download
M services/service_manager/public/cpp/typemaps.gni View 1 1 chunk +1 line, -0 lines 0 comments Download
M services/service_manager/public/interfaces/interface_provider_spec.mojom View 1 1 chunk +5 lines, -0 lines 0 comments Download
M services/service_manager/public/interfaces/resolver.mojom View 1 2 3 4 5 6 11 1 chunk +6 lines, -3 lines 0 comments Download
M services/service_manager/public/interfaces/service.mojom View 1 4 chunks +13 lines, -4 lines 0 comments Download
M services/service_manager/public/interfaces/service_manager.mojom View 1 2 chunks +3 lines, -3 lines 0 comments Download
M services/service_manager/service_manager.h View 1 1 chunk +1 line, -1 line 0 comments Download
M services/service_manager/service_manager.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 19 chunks +60 lines, -34 lines 0 comments Download
M services/service_manager/tests/lifecycle/lifecycle_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M services/service_manager/tests/service_manager/service_manager_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 64 (50 generated)
Ben Goodger (Google)
ken: * tom: *.mojom, *struct_traits.h
4 years, 2 months ago (2016-10-20 19:44:35 UTC) #19
Tom Sepez
lgtm
4 years, 2 months ago (2016-10-20 20:06:14 UTC) #20
Ken Rockot(use gerrit already)
lgtm
4 years, 2 months ago (2016-10-20 23:00:47 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2425563004/140001
4 years, 2 months ago (2016-10-20 23:38:21 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/316579)
4 years, 2 months ago (2016-10-21 01:34:52 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2425563004/200001
4 years, 2 months ago (2016-10-21 04:52:51 UTC) #39
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/302696)
4 years, 2 months ago (2016-10-21 06:05:38 UTC) #41
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2425563004/220001
4 years, 1 month ago (2016-10-24 17:54:51 UTC) #46
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/301483)
4 years, 1 month ago (2016-10-24 19:33:29 UTC) #48
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2425563004/260001
4 years, 1 month ago (2016-10-24 23:00:10 UTC) #55
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/322812)
4 years, 1 month ago (2016-10-25 00:07:57 UTC) #57
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2425563004/280001
4 years, 1 month ago (2016-10-25 06:30:26 UTC) #60
commit-bot: I haz the power
Committed patchset #15 (id:280001)
4 years, 1 month ago (2016-10-25 08:36:07 UTC) #62
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 08:40:26 UTC) #64
Message was sent while issue was closed.
Patchset 15 (id:??) landed as
https://crrev.com/cd6411161764cae700abf1699c10ecbdb2c54a39
Cr-Commit-Position: refs/heads/master@{#427299}

Powered by Google App Engine
This is Rietveld 408576698