Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 2425563002: Revert of Upgrade to new Android SDK. (Closed)

Created:
4 years, 2 months ago by nednguyen
Modified:
4 years, 2 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Upgrade to new Android SDK. (patchset #16 id:300001 of https://codereview.chromium.org/2350013004/ ) Reason for revert: This may have changed the adb used by adb_logcat_monitor.py & creates a conflict with the one used by telemetry. BUG=656224 Original issue's description: > Upgrade to new Android SDK. > > BUG=623989 > > Committed: https://crrev.com/e3c21739bcc8d5df70d2dd011c3f575570085b6d > Cr-Commit-Position: refs/heads/master@{#425423} TBR=jbudorick@chromium.org,xunjieli@chromium.org,agrieve@chromium.org,stip@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=623989 Committed: https://crrev.com/3d5a0fb164db4c2c24e83fe859463aa4268918a4 Cr-Commit-Position: refs/heads/master@{#425604}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -118 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M build/android/BUILD.gn View 1 chunk +4 lines, -4 lines 0 comments Download
M build/android/devil_chromium.json View 3 chunks +3 lines, -3 lines 0 comments Download
M build/android/lint/suppressions.xml View 4 chunks +1 line, -98 lines 0 comments Download
M build/android/pylib/constants/__init__.py View 1 chunk +1 line, -1 line 0 comments Download
M build/config/android/config.gni View 1 chunk +2 lines, -2 lines 0 comments Download
M components/cronet/android/api/build.xml View 1 chunk +1 line, -1 line 0 comments Download
M components/cronet/tools/generate_javadoc.py View 1 chunk +1 line, -3 lines 0 comments Download
M docs/android_test_instructions.md View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/android/eclipse/.classpath View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
nednguyen
Created Revert of Upgrade to new Android SDK.
4 years, 2 months ago (2016-10-17 00:23:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2425563002/1
4 years, 2 months ago (2016-10-17 00:24:07 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-17 01:37:11 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 01:40:41 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3d5a0fb164db4c2c24e83fe859463aa4268918a4
Cr-Commit-Position: refs/heads/master@{#425604}

Powered by Google App Engine
This is Rietveld 408576698