Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1026)

Issue 2425553003: Move PromiseNextMicrotaskID to cpp (Closed)

Created:
4 years, 2 months ago by gsathya
Modified:
4 years, 2 months ago
Reviewers:
Dan Ehrenberg, adamk
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Move PromiseNextMicrotaskID to cpp BUG=v8:5343 Committed: https://crrev.com/0d8b253c345b4f1c082a97a278ffa3a0f26a5dda Cr-Commit-Position: refs/heads/master@{#40405}

Patch Set 1 #

Patch Set 2 : Fix build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M src/isolate.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/js/async-await.js View 2 chunks +1 line, -2 lines 0 comments Download
M src/js/promise.js View 4 chunks +2 lines, -9 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-debug.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
gsathya
4 years, 2 months ago (2016-10-17 18:25:32 UTC) #4
Dan Ehrenberg
lgtm
4 years, 2 months ago (2016-10-17 20:04:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2425553003/20001
4 years, 2 months ago (2016-10-18 15:38:55 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-18 15:41:37 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-18 15:41:54 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0d8b253c345b4f1c082a97a278ffa3a0f26a5dda
Cr-Commit-Position: refs/heads/master@{#40405}

Powered by Google App Engine
This is Rietveld 408576698