Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(708)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2425543002: Removed use of IsRunningOnIOS8OrLater (Closed)

Created:
4 years, 2 months ago by pkl (ping after 24h if needed)
Modified:
4 years, 2 months ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews, gcasto+watchlist_chromium.org, mac-reviews_chromium.org, vabr+watchlistpasswordmanager_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed use of IsRunningOnIOS8OrLater BUG=633626 Committed: https://crrev.com/a29c5278349056b612dcad4efe6257e13ee20149 Cr-Commit-Position: refs/heads/master@{#425677}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M ios/chrome/browser/passwords/credential_manager.mm View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
pkl (ping after 24h if needed)
Just cleaning up.
4 years, 2 months ago (2016-10-17 13:57:10 UTC) #2
vabr (Chromium)
LGTM, thank you! Vaclav
4 years, 2 months ago (2016-10-17 14:05:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2425543002/1
4 years, 2 months ago (2016-10-17 14:12:22 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-17 14:22:03 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 14:25:06 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/a29c5278349056b612dcad4efe6257e13ee20149
Cr-Commit-Position: refs/heads/master@{#425677}

Powered by Google App Engine
This is Rietveld 408576698