Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Side by Side Diff: appengine/findit/templates/waterfall/test_failure.html

Issue 2425513002: [Findit] Fix bug on non-admin UI for unclassified_failure. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 {% extends "build_failure.html" %} 1 {% extends "build_failure.html" %}
2 2
3 {% block title %}Test{% endblock title %} 3 {% block title %}Test{% endblock title %}
4 4
5 {% block style %} 5 {% block style %}
6 .not-display, .hidden-row { 6 .not-display, .hidden-row {
7 display: none; 7 display: none;
8 } 8 }
9 .truncate { 9 .truncate {
10 width: 500px; 10 width: 500px;
(...skipping 204 matching lines...) Expand 10 before | Expand all | Expand 10 after
215 } 215 }
216 216
217 function displayUnclassifiedFailures(step_name, results) { 217 function displayUnclassifiedFailures(step_name, results) {
218 if (!jQuery.isEmptyObject(results)) { 218 if (!jQuery.isEmptyObject(results)) {
219 var tableString = ''; 219 var tableString = '';
220 $.each(results, function(index, result) { 220 $.each(results, function(index, result) {
221 tableString += '<tr>'; 221 tableString += '<tr>';
222 var rowspan = result.heuristic_analysis.suspected_cls.length > 0 ? res ult.heuristic_analysis.suspected_cls.length : 1; 222 var rowspan = result.heuristic_analysis.suspected_cls.length > 0 ? res ult.heuristic_analysis.suspected_cls.length : 1;
223 tableString += generateCommonCellsForAllCategories(step_name, 'undeter mined', index, result.tests, result.first_failure, result.last_pass, rowspan); 223 tableString += generateCommonCellsForAllCategories(step_name, 'undeter mined', index, result.tests, result.first_failure, result.last_pass, rowspan);
224 224
225 tableString += '<td id="unclassified_reason_td" rowspan="' + rowspan + '">' + findit.tryjobStatusMessageMap[result.try_job.status] + '</td>';
226 tableString += generateHeuristicCulpritCls(result.heuristic_analysis.s uspected_cls, result.supported); 225 tableString += generateHeuristicCulpritCls(result.heuristic_analysis.s uspected_cls, result.supported);
227 tableString += '</tr>'; 226 tableString += '</tr>';
228 }); 227 });
229 228
230 $('#unclassified_failures_table tbody').append(tableString); 229 $('#unclassified_failures_table tbody').append(tableString);
231 $('#unclassified_failures').removeClass('not-display'); 230 $('#unclassified_failures').removeClass('not-display');
232
233 // Do not display Reason to non-admin users.
234 if (! findit.showDebugInfo) {
235 $('#unclassified_reason_th').addClass('not-display');
236 $('#unclassified_reason_td').addClass('not-display');
237 }
238 } 231 }
239 } 232 }
240 233
241 function displayUnclassifiedFailuresToAdmins(step_name, results) { 234 function displayUnclassifiedFailuresToAdmins(step_name, results) {
242 if (!jQuery.isEmptyObject(results)) { 235 if (!jQuery.isEmptyObject(results)) {
243 var tableString = ''; 236 var tableString = '';
244 $.each(results, function(index, result) { 237 $.each(results, function(index, result) {
245 tableString += '<tr>'; 238 tableString += '<tr>';
246 var rowspan = result.heuristic_analysis.suspected_cls.length > 0 ? res ult.heuristic_analysis.suspected_cls.length : 1; 239 var rowspan = result.heuristic_analysis.suspected_cls.length > 0 ? res ult.heuristic_analysis.suspected_cls.length : 1;
247 240
(...skipping 165 matching lines...) Expand 10 before | Expand all | Expand 10 after
413 406
414 <div id="unclassified_failures" class='not-display'> 407 <div id="unclassified_failures" class='not-display'>
415 <b>Unclassified failures</b> 408 <b>Unclassified failures</b>
416 <table id="unclassified_failures_table"> 409 <table id="unclassified_failures_table">
417 <thead> 410 <thead>
418 <tr> 411 <tr>
419 <th rowspan="3" title="Failed step name" width="150px">Step</t h> 412 <th rowspan="3" title="Failed step name" width="150px">Step</t h>
420 <th rowspan="3" title="Failed test name" width="300px">Test(s) </th> 413 <th rowspan="3" title="Failed test name" width="300px">Test(s) </th>
421 <th rowspan="3" title="The build cycle in which the step start ed to fail">First Failure</th> 414 <th rowspan="3" title="The build cycle in which the step start ed to fail">First Failure</th>
422 <th rowspan="3" title="The last build cycle in which the step passed">Last Pass<br>Before Failure</th> 415 <th rowspan="3" title="The last build cycle in which the step passed">Last Pass<br>Before Failure</th>
423 <th id="unclassified_reason_th" rowspan="3" title="The reason we're not sure about the result">Reason</th>
424 <th colspan="4">Suspected CLs</th> 416 <th colspan="4">Suspected CLs</th>
425 </tr> 417 </tr>
426 <tr> 418 <tr>
427 <th colspan="4">Heuristic Analysis Result</th> 419 <th colspan="4">Heuristic Analysis Result</th>
428 </tr> 420 </tr>
429 <tr> 421 <tr>
430 <th title="The build cycle in which the CL was built or tested for the first time">Build Number</th> 422 <th title="The build cycle in which the CL was built or tested for the first time">Build Number</th>
431 <th title="Git commit position/hash">Commit</th> 423 <th title="Git commit position/hash">Commit</th>
432 <th title="The higher score, the more suspected">Score (<a cla ss="score-info" href="javascript:">?</a>)</th> 424 <th title="The higher score, the more suspected">Score (<a cla ss="score-info" href="javascript:">?</a>)</th>
433 <th title="Why this CL is related to the failure">Hints</th> 425 <th title="Why this CL is related to the failure">Hints</th>
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
465 <th title="Why this CL is related to the failure">Hints</th> 457 <th title="Why this CL is related to the failure">Hints</th>
466 </tr> 458 </tr>
467 </thead> 459 </thead>
468 <tbody> 460 <tbody>
469 </tbody> 461 </tbody>
470 </table> 462 </table>
471 <br> 463 <br>
472 </div> 464 </div>
473 {% endif %} 465 {% endif %}
474 {% endblock result_tables %} 466 {% endblock result_tables %}
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698