Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Issue 24255018: Side three of two-sided patch for URL encoding. Restores tests expectations. (Closed)

Created:
7 years, 3 months ago by Tom Sepez
Modified:
7 years, 3 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), dstockwell, Timothy Loh, darktears, Steve Block, dino_apple.com, Eric Willigers
Visibility:
Public.

Description

Side three of two-sided patch for URL encoding. Restores tests expectations. BUG=292740 R=abarth@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158298

Patch Set 1 #

Patch Set 2 : Remove strays from upload. #

Patch Set 3 : Missing two platform origin-exact-matching-expected.txt files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -108 lines) Patch
M LayoutTests/TestExpectations View 2 chunks +1 line, -49 lines 0 comments Download
M LayoutTests/fast/frames/xss-auditor-handles-file-urls-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/base-href-control-char-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/base-href-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/base-href-null-char-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/base-href-scheme-relative-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/embed-tag-control-char-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/embed-tag-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/embed-tag-javascript-url-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/embed-tag-null-char-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/form-action-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/formaction-on-button-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/formaction-on-input-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/frameset-injection-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/full-block-base-href-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/full-block-link-onclick-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/full-block-object-tag-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/full-block-script-tag-with-source-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/iframe-injection-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/iframe-javascript-url-more-encoding-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/img-onerror-non-ASCII-char-default-encoding-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/img-onerror-non-ASCII-char-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/link-onclick-ampersand-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/link-onclick-control-char-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/link-onclick-entities-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/link-onclick-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/link-onclick-null-char-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/object-embed-tag-control-char-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/object-embed-tag-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/object-embed-tag-null-char-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/object-tag-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/object-tag-javascript-url-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/script-tag-with-16bit-unicode4-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/script-tag-with-16bit-unicode5-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/script-tag-with-comma-01-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/script-tag-with-source-control-char-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/script-tag-with-source-entities-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/script-tag-with-source-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/script-tag-with-source-null-char-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/script-tag-with-source-same-host-with-query-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/svg-animate-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/svg-script-tag-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/xss-filter-bypass-big5-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/xssAuditor/xss-filter-bypass-sjis-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/xmlhttprequest/origin-exact-matching-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/linux/http/tests/xmlhttprequest/origin-exact-matching-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/mac-snowleopard/http/tests/xmlhttprequest/origin-exact-matching-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/weborigin/KURLTest.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Tom Sepez
Adam, please review. Should be only re-setting test expectations.
7 years, 3 months ago (2013-09-24 17:36:55 UTC) #1
abarth-chromium
Lgtm rs=me On Tuesday, September 24, 2013, <tsepez@chromium.org> wrote: > Reviewers: abarth, > > Message: ...
7 years, 3 months ago (2013-09-24 20:51:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tsepez@chromium.org/24255018/7001
7 years, 3 months ago (2013-09-24 20:52:43 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-09-25 06:07:47 UTC) #4
Message was sent while issue was closed.
Change committed as 158298

Powered by Google App Engine
This is Rietveld 408576698