Issue 24255017: GTTF: add independent test timeout for the test launcher

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24255017: GTTF: add independent test timeout for the test launcher (Closed)

Created:
7 years, 3 months ago by Paweł Hajdan Jr.

Modified:
7 years, 3 months ago

Reviewers:
sky

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

GTTF: add independent test timeout for the test launcher Otherwise when increasing action timeout some tests actually start taking longer (they probably sleep). Also change test status to timeout for tests in a batch that completed but took longer than the timeout so that the outcome is not dependent on test order and similar factors. BUG=236893 R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=225013

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -1 line)			Patch
M	base/test/test_switches.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	base/test/test_switches.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	base/test/test_timeouts.h	View	2 chunks	+8 lines, -0 lines	0 comments	Download
M	base/test/test_timeouts.cc	View	2 chunks	+8 lines, -0 lines	0 comments	Download
M	base/test/unit_test_launcher.cc	View	2 chunks	+12 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Paweł Hajdan Jr.

7 years, 3 months ago (2013-09-24 17:00:20 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r225013 (presubmit successful).

Expand Messages | Collapse Messages