Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 24255005: Some cleanup fixes (Closed)

Created:
7 years, 3 months ago by mvstanton
Modified:
7 years, 3 months ago
CC:
v8-dev
Visibility:
Public.

Description

Some cleanup fixes * Consolidated CopyJSObject and CopyJSObjectWithAllocationSite * Factory.h helper for struct maps. * BuildFastLiteral shouldn't create allocation sites in pretenuring mode. BUG= R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16855

Patch Set 1 #

Patch Set 2 : More fixes #

Patch Set 3 : REBASE #

Total comments: 2

Patch Set 4 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -163 lines) Patch
M src/arm/code-stubs-arm.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/code-stubs-hydrogen.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M src/factory.h View 1 chunk +9 lines, -1 line 0 comments Download
M src/heap.h View 1 2 3 1 chunk +3 lines, -4 lines 0 comments Download
M src/heap.cc View 5 chunks +17 lines, -115 lines 0 comments Download
M src/hydrogen.cc View 1 2 4 chunks +23 lines, -13 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/mips/code-stubs-mips.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/runtime.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 5 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
mvstanton
Hi guys, here most of the changes from a review of the allocsite code Toon ...
7 years, 3 months ago (2013-09-19 15:33:43 UTC) #1
Michael Starzinger
LGTM with nit. https://codereview.chromium.org/24255005/diff/6001/src/heap.h File src/heap.h (left): https://codereview.chromium.org/24255005/diff/6001/src/heap.h#oldcode1010 src/heap.h:1010: // Allocates a new utility object ...
7 years, 3 months ago (2013-09-19 16:45:25 UTC) #2
mvstanton
thx, I added the comment back! --Michael https://codereview.chromium.org/24255005/diff/6001/src/heap.h File src/heap.h (left): https://codereview.chromium.org/24255005/diff/6001/src/heap.h#oldcode1010 src/heap.h:1010: // Allocates ...
7 years, 3 months ago (2013-09-20 09:19:15 UTC) #3
mvstanton
7 years, 3 months ago (2013-09-20 09:27:55 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 manually as r16855 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698