Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 2425493002: Remove usage of FOR_EACH_OBSERVER macro in blimp (Closed)

Created:
4 years, 2 months ago by Eric Willigers
Modified:
4 years, 2 months ago
Reviewers:
Wez
CC:
chromium-reviews, cbentzel+watch_chromium.org, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, bgoldman+watch-blimp_chromium.org, steimel+watch-blimp_chromium.org, gcasto+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, perumaal+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, dtrainor+watch-blimp_chromium.org, scf+watch-blimp_chromium.org, khushalsagar+watch-blimp_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove usage of FOR_EACH_OBSERVER macro in blimp Observer lists now support range-based for loops. BUG=655021 Committed: https://crrev.com/08199f18817ec5b16b50946cecd40739561bfb01 Cr-Commit-Position: refs/heads/master@{#425768}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -15 lines) Patch
M blimp/client/core/contents/blimp_contents_impl.cc View 2 chunks +8 lines, -7 lines 0 comments Download
M blimp/client/core/session/connection_status.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M blimp/engine/app/settings_manager.cc View 1 chunk +2 lines, -1 line 0 comments Download
M blimp/engine/app/ui/blimp_screen.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M blimp/net/blimp_connection.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Eric Willigers
4 years, 2 months ago (2016-10-15 13:12:01 UTC) #6
Wez
lgtm
4 years, 2 months ago (2016-10-17 19:02:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2425493002/1
4 years, 2 months ago (2016-10-17 19:03:16 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-17 20:33:53 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 20:35:32 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/08199f18817ec5b16b50946cecd40739561bfb01
Cr-Commit-Position: refs/heads/master@{#425768}

Powered by Google App Engine
This is Rietveld 408576698