Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Unified Diff: media/renderers/audio_renderer_impl_unittest.cc

Issue 2425463002: Improve HTMLMediaElement::currentTime() (Closed)
Patch Set: Merge Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/renderers/audio_renderer_impl_unittest.cc
diff --git a/media/renderers/audio_renderer_impl_unittest.cc b/media/renderers/audio_renderer_impl_unittest.cc
index c5b51afbc155b9fb95a4a7c029f33d798d1243b5..3fdee31ffff59d8caf9f00ae24043b7ab7cdb96e 100644
--- a/media/renderers/audio_renderer_impl_unittest.cc
+++ b/media/renderers/audio_renderer_impl_unittest.cc
@@ -748,13 +748,7 @@ TEST_F(AudioRendererImplTest, CurrentMediaTimeBehavior) {
StopTicking();
EXPECT_EQ(timestamp_helper.GetTimestamp(), CurrentMediaTime());
tick_clock_->Advance(kConsumptionDuration * 2);
-
- // TODO(chcunningham): Uncomment the AddFrames() call below. AudioClock should
- // be expected to advance time through the last rendered buffer's samples, but
- // we've currently capped it to not advance time after ticking stops as a
- // short term workaround for messy blink code. See longterm solution at
- // http://crrev.com/2425463002.
- // timestamp_helper.AddFrames(frames_to_consume.value);
+ timestamp_helper.AddFrames(frames_to_consume.value);
EXPECT_EQ(timestamp_helper.GetTimestamp(), CurrentMediaTime());
}

Powered by Google App Engine
This is Rietveld 408576698