cros: Removed some zones in the middle of the pin keyboard that do not accept touches.

cros: Removed some zones in the middle of the pin keyboard that do not accept touches.

Previously the parts of the pin keyboard which are not covered by the button ripple do nothing on touch. This includes the corners of each button as well as the space between each button horizontally. I fix this by hiding the paper-button ripple and adding a new one so that it is still compliant with mocks.

BUG=656159, 655306
TEST=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/6c0b4e4776ecbccdfd5a30027f306c5041275773
Cr-Commit-Position: refs/heads/master@{#426103}

[sammiequon, 2016-10-15 00:18:07]

Description was changed from

==========
cros: Removed some zones in the middle of the pin keyboard that do not accept
touches.

Previously the parts of the pin keyboard which are not covered by the button
ripple do nothing on touch. This includes the corners of each button as well as
the space between each button horizontally. I fix this by hiding the
paper-button ripple and adding a new one so that it is still compilant with
mocks.

BUG= 656159, 655306
TEST=none
==========

to

==========
cros: Removed some zones in the middle of the pin keyboard that do not accept
touches.

Previously the parts of the pin keyboard which are not covered by the button
ripple do nothing on touch. This includes the corners of each button as well as
the space between each button horizontally. I fix this by hiding the
paper-button ripple and adding a new one so that it is still compilant with
mocks.

BUG= 656159, 655306
TEST=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[sammiequon, 2016-10-15 00:19:18]

Patchset #1 (id:1) has been deleted

[sammiequon, 2016-10-15 00:22:53]

Description was changed from

==========
cros: Removed some zones in the middle of the pin keyboard that do not accept
touches.

Previously the parts of the pin keyboard which are not covered by the button
ripple do nothing on touch. This includes the corners of each button as well as
the space between each button horizontally. I fix this by hiding the
paper-button ripple and adding a new one so that it is still compilant with
mocks.

BUG= 656159, 655306
TEST=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
cros: Removed some zones in the middle of the pin keyboard that do not accept
touches.

Previously the parts of the pin keyboard which are not covered by the button
ripple do nothing on touch. This includes the corners of each button as well as
the space between each button horizontally. I fix this by hiding the
paper-button ripple and adding a new one so that it is still compilant with
mocks.

BUG= 656159, 655306
TEST=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[sammiequon, 2016-10-15 00:22:53]

sammiequon@chromium.org changed reviewers:
+ jdufault@chromium.org

[sammiequon, 2016-10-15 00:23:14]

On 2016/10/15 00:22:53, sammiequon wrote:
> mailto:sammiequon@chromium.org changed reviewers:
> + mailto:jdufault@chromium.org

jdufault@ - Please take a look. Thanks!

[jdufault, 2016-10-17 19:25:14]

Did you verify the keyboard still works and looks as expected from
options/settings?

https://codereview.chromium.org/2425443002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.js (right):

https://codereview.chromium.org/2425443002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.js:104:
digitButtons[i].noink = true;
Set this inside of the HTML?

  <paper-button noink class="digit-button" ...>

[sammiequon, 2016-10-17 23:56:06]

On 2016/10/17 19:25:14, jdufault wrote:
> Did you verify the keyboard still works and looks as expected from
> options/settings?
> 
>
https://codereview.chromium.org/2425443002/diff/20001/chrome/browser/resource...
> File chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.js (right):
> 
>
https://codereview.chromium.org/2425443002/diff/20001/chrome/browser/resource...
> chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.js:104:
> digitButtons[i].noink = true;
> Set this inside of the HTML?
> 
>   <paper-button noink class="digit-button" ...>

Yes. I assume it would've also the same issue as the lock screen prior to this
patch.

[sammiequon, 2016-10-17 23:56:14]

https://codereview.chromium.org/2425443002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.js (right):

https://codereview.chromium.org/2425443002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.js:104:
digitButtons[i].noink = true;
On 2016/10/17 19:25:13, jdufault wrote:
> Set this inside of the HTML?
> 
>   <paper-button noink class="digit-button" ...>

Done.

[jdufault, 2016-10-18 17:47:17]

lgtm

[sammiequon, 2016-10-18 20:40:04]

sammiequon@chromium.org changed reviewers:
+ xiyuan@chromium.org

[sammiequon, 2016-10-18 20:40:15]

The CQ bit was checked by sammiequon@chromium.org to run a CQ dry run

[sammiequon, 2016-10-18 20:40:34]

On 2016/10/18 17:47:17, jdufault wrote:
> lgtm

xiyuan@ - Please take a look. Thanks!

[commit-bot: I haz the power, 2016-10-18 20:40:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xiyuan, 2016-10-18 21:15:44]

lgtm

[xiyuan, 2016-10-18 21:18:01]

On 2016/10/18 21:15:44, xiyuan wrote:
> lgtm

In CL description
  compilant -> compliant

[sammiequon, 2016-10-18 21:39:31]

Description was changed from

==========
cros: Removed some zones in the middle of the pin keyboard that do not accept
touches.

Previously the parts of the pin keyboard which are not covered by the button
ripple do nothing on touch. This includes the corners of each button as well as
the space between each button horizontally. I fix this by hiding the
paper-button ripple and adding a new one so that it is still compilant with
mocks.

BUG= 656159, 655306
TEST=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
cros: Removed some zones in the middle of the pin keyboard that do not accept
touches.

Previously the parts of the pin keyboard which are not covered by the button
ripple do nothing on touch. This includes the corners of each button as well as
the space between each button horizontally. I fix this by hiding the
paper-button ripple and adding a new one so that it is still compliant with
mocks.

BUG= 656159, 655306
TEST=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-10-18 21:43:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-18 21:43:08]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sammiequon, 2016-10-18 23:38:46]

The CQ bit was checked by sammiequon@chromium.org

[commit-bot: I haz the power, 2016-10-18 23:39:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 00:23:44]

Description was changed from

==========
cros: Removed some zones in the middle of the pin keyboard that do not accept
touches.

Previously the parts of the pin keyboard which are not covered by the button
ripple do nothing on touch. This includes the corners of each button as well as
the space between each button horizontally. I fix this by hiding the
paper-button ripple and adding a new one so that it is still compliant with
mocks.

BUG= 656159, 655306
TEST=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
cros: Removed some zones in the middle of the pin keyboard that do not accept
touches.

Previously the parts of the pin keyboard which are not covered by the button
ripple do nothing on touch. This includes the corners of each button as well as
the space between each button horizontally. I fix this by hiding the
paper-button ripple and adding a new one so that it is still compliant with
mocks.

BUG= 656159, 655306
TEST=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-10-19 00:23:45]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-10-21 13:05:20]

Description was changed from

==========
cros: Removed some zones in the middle of the pin keyboard that do not accept
touches.

Previously the parts of the pin keyboard which are not covered by the button
ripple do nothing on touch. This includes the corners of each button as well as
the space between each button horizontally. I fix this by hiding the
paper-button ripple and adding a new one so that it is still compliant with
mocks.

BUG= 656159, 655306
TEST=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
cros: Removed some zones in the middle of the pin keyboard that do not accept
touches.

Previously the parts of the pin keyboard which are not covered by the button
ripple do nothing on touch. This includes the corners of each button as well as
the space between each button horizontally. I fix this by hiding the
paper-button ripple and adding a new one so that it is still compliant with
mocks.

BUG= 656159, 655306
TEST=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/6c0b4e4776ecbccdfd5a30027f306c5041275773
Cr-Commit-Position: refs/heads/master@{#426103}
==========

[commit-bot: I haz the power, 2016-10-21 13:05:21]

Patchset 2 (id:??) landed as
https://crrev.com/6c0b4e4776ecbccdfd5a30027f306c5041275773
Cr-Commit-Position: refs/heads/master@{#426103}