Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 2425423009: Split out options from ContextBuilder (Closed)

Created:
4 years, 2 months ago by Brian Wilkerson
Modified:
4 years, 2 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -101 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 1 chunk +9 lines, -7 lines 0 comments Download
M pkg/analysis_server/test/context_manager_test.dart View 1 chunk +5 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/context/builder.dart View 11 chunks +94 lines, -69 lines 0 comments Download
M pkg/analyzer/test/src/context/builder_test.dart View 11 chunks +17 lines, -10 lines 0 comments Download
M pkg/analyzer/test/stress/for_git_repository.dart View 1 chunk +5 lines, -3 lines 0 comments Download
M pkg/analyzer/tool/task_dependency_graph/generate.dart View 1 chunk +7 lines, -5 lines 0 comments Download
M pkg/analyzer_cli/lib/src/driver.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/dev_compiler/lib/src/analyzer/context.dart View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
4 years, 2 months ago (2016-10-20 16:22:31 UTC) #2
scheglov
LGTM
4 years, 2 months ago (2016-10-20 16:24:48 UTC) #3
Brian Wilkerson
4 years, 2 months ago (2016-10-20 18:03:17 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
96750cd5cb734b98cf979331a3664587faa6b7e5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698