MD Settings: Close action menu when search engine is removed.

chrome/test/data/webui/settings/search_engines_page_test.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('settings_search_engines_page', function() {
   /**
    * @param {boolean} canBeDefault
    * @param {boolean} canBeEdited
    * @param {boolean} canBeRemoved
    * @return {!SearchEngine}
@@ skipping 158 matching lines @@
         var keywordElement = entry.$$('.keyword-column');
         assertTrue(!!keywordElement);
         assertEquals(searchEngine.keyword, keywordElement.textContent);
 
         var urlElement = entry.$$('.url-column');
         assertTrue(!!urlElement);
         assertEquals(searchEngine.url, urlElement.textContent);
       });
 
       test('Remove_Enabled', function() {
+        // Open action menu.
+        MockInteractions.tap(entry.$$('paper-icon-button'));
+        var menu = entry.$$('dialog[is=settings-action-menu]');
+        assertTrue(menu.open);
+

[hcarmona, 2016/10/19 18:10:31]

extra space (sorry for nittiest of nits!)

[dpapad, 2016/10/19 18:53:21]

Done, no problem!

+
         var deleteButton = entry.$.delete;
         assertTrue(!!deleteButton);
         assertFalse(deleteButton.hidden);
         MockInteractions.tap(deleteButton);
         return browserProxy.whenCalled('removeSearchEngine').then(
             function(modelIndex) {
+              assertFalse(menu.open);
               assertEquals(entry.engine.modelIndex, modelIndex);
             });
       });
 
       test('MakeDefault_Enabled', function() {
         // Open action menu.
         MockInteractions.tap(entry.$$('paper-icon-button'));
+        var menu = entry.$$('dialog[is=settings-action-menu]');
+        assertTrue(menu.open);
 
         var makeDefaultButton = entry.$.makeDefault;
         assertTrue(!!makeDefaultButton);
         MockInteractions.tap(makeDefaultButton);
         return browserProxy.whenCalled('setDefaultSearchEngine').then(
             function(modelIndex) {
+              assertFalse(menu.open);
               assertEquals(entry.engine.modelIndex, modelIndex);
             });
       });
 
       // Test that clicking the "edit" button brings up a dialog.
       test('Edit_Enabled', function() {
         // Open action menu.
         MockInteractions.tap(entry.$$('paper-icon-button'));
+        var menu = entry.$$('dialog[is=settings-action-menu]');
+        assertTrue(menu.open);
 
         var engine = entry.engine;
         var editButton = entry.$.edit;
         assertTrue(!!editButton);
         assertFalse(editButton.hidden);
         MockInteractions.tap(editButton);
         return browserProxy.whenCalled('searchEngineEditStarted').then(
             function(modelIndex) {
               assertEquals(engine.modelIndex, modelIndex);
               var dialog = entry.$$('settings-search-engine-dialog');
@@ skipping 151 matching lines @@
 
   return {
     registerTests: function() {
       registerDialogTests();
       registerSearchEngineEntryTests();
       registerOmniboxExtensionEntryTests();
       registerPageTests();
     },
   };
 });