android_webview/java/src/org/chromium/android_webview/AwContentsClientBridge.java - Issue 2425423004: Move NewDownload out of AwContentsIoThreadClientImpl to AwContentsClientBridge

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwContentsClientBridge.java

Issue 2425423004: Move NewDownload out of AwContentsIoThreadClientImpl to AwContentsClientBridge (Closed)

Patch Set: changed "even if" to "unless" Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.cc ('K') | « android_webview/java/src/org/chromium/android_webview/AwContents.java ('k') | android_webview/java/src/org/chromium/android_webview/AwContentsIoThreadClient.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/java/src/org/chromium/android_webview/AwContentsClientBridge.java

diff --git a/android_webview/java/src/org/chromium/android_webview/AwContentsClientBridge.java b/android_webview/java/src/org/chromium/android_webview/AwContentsClientBridge.java

index cbfb616d335387e30f1924583568025454cc776d..e7d4e4c27c3fb238d3f4490f34c99513b4ac9895 100644

--- a/android_webview/java/src/org/chromium/android_webview/AwContentsClientBridge.java

+++ b/android_webview/java/src/org/chromium/android_webview/AwContentsClientBridge.java

@@ -251,6 +251,13 @@ public class AwContentsClientBridge {

mClient.handleJsBeforeUnload(url, message, handler);

}

+ @CalledByNative

+ private void newDownload(String url, String userAgent, String contentDisposition,

+ String mimeType, long contentLength) {

+ mClient.getCallbackHelper().postOnDownloadStart(

+ url, userAgent, contentDisposition, mimeType, contentLength);

+ }

@CalledByNativeUnchecked

private boolean shouldOverrideUrlLoading(

String url, boolean hasUserGesture, boolean isRedirect, boolean isMainFrame) {